fix(dev-tools): ensure that bump is minimal so that later release sort properly #10878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
bump_version.pywhere we were originally bumping to major, but that results in an incorrect ordering when the next release after a pre-release is not a major release.For example,
Let's say the current version is 10.0.0, and the next release will be 10.1.0--a feature release. If the pre-release is published as 11.0.0.devNNN then the 10.1.0 release will sort before the pre-release, which is incorrect.
The solution is to always bump the pre-release by only its minor version.