Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-formatting all files using pre-commit hook #1963

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Re-formatting all files using pre-commit hook #1963

merged 1 commit into from
Sep 13, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Sep 10, 2019 •
edited
Loading

waiting for PyCQA/isort#1000

This was referenced Sep 11, 2019
Merged
Merged
@codecov
Copy link

codecov bot commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #1963 into master will decrease coverage by 1.53%.
The diff coverage is 90.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   87.67%   86.14%   -1.54%     
==========================================
  Files          93       93              
  Lines       17088    17088              
  Branches     2159     2159              
==========================================
- Hits        14982    14720     -262     
- Misses       1690     1963     +273     
+ Partials      416      405      -11
Impacted Files Coverage Δ
ibis/expr/signature.py 100% <ø> (ø) ⬆️
ibis/pyspark/client.py 92.3% <ø> (ø) ⬆️
ibis/impala/api.py 80% <ø> (ø) ⬆️
ibis/expr/datatypes.py 94.65% <ø> (+0.23%) ⬆️
ibis/spark/udf.py 94.2% <ø> (ø) ⬆️
ibis/spark/datatypes.py 81.66% <ø> (ø) ⬆️
ibis/expr/types.py 93.97% <ø> (ø) ⬆️
ibis/pandas/execution/temporal.py 86.04% <ø> (ø) ⬆️
ibis/expr/schema.py 90.1% <ø> (-1.1%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
... and 35 more

@xmnlab xmnlab marked this pull request as ready for review September 12, 2019 14:20
@toryhaavik
Copy link
Contributor

You probably want to rebase on top of master, and that will turn off the codecov plugin.

@xmnlab
Copy link
Contributor Author

xmnlab commented Sep 12, 2019

@toryhaavik actually I already rebased it. but it seems github didn't understand this change.
it is done for a review.

toryhaavik
toryhaavik approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@toryhaavik toryhaavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this! Let's keep everything nicely formatted going forward!

@toryhaavik toryhaavik merged commit ae71b3a into ibis-project:master Sep 13, 2019
@xmnlab xmnlab deleted the black-files-formatting branch September 27, 2019 21:38
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
@xmnlab @costrouc
Re-formatting all files using pre-commit hook
2928542 
waiting for PyCQA/isort#1000
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes ibis-project#1963 from xmnlab/black-files-formatting and squashes the following commits:

9d1defb [Ivan Ogasawara] Re-formatting all files using pre-commit hook
@ian-r-rose ian-r-rose mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toryhaavik toryhaavik toryhaavik approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmnlab @toryhaavik