feat: remove .case(), move to .cases() #7914
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #7319 targeting main instead of master
Fixes #7280
This is still WIP for getting all tests to pass, but putting something concrete out here for feedback. I would love you initial thoughts here.
TODO:
Questions:
t.values.cases((_ > 5), "big"), else_="small")
. This doesn't work currently either, so we're not moving backwards.instead of what it used to:
IDK if this has any performance penalty (the previous SQL looks ripe for a hash lookup, the new SQL does not, but IDK duckdb is probably smart enough to get around this)