Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): make pyarrow optional for non-backend installs #9552

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 11, 2024

Make pyarrow an optional dependency for installs that do not require a backend.

@cpcloud cpcloud added the dependencies Issues or PRs related to dependencies label Jul 11, 2024
@cpcloud cpcloud marked this pull request as draft July 11, 2024 14:14
@cpcloud cpcloud force-pushed the pyarrow-optional branch 2 times, most recently from 7ec4ea8 to 9b3f876 Compare July 11, 2024 14:27
@cpcloud cpcloud marked this pull request as ready for review July 11, 2024 15:02
@cpcloud cpcloud force-pushed the pyarrow-optional branch from 9926b05 to 384c54d Compare July 11, 2024 15:07
@cpcloud cpcloud requested a review from gforsyth July 11, 2024 15:19
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Jul 11, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #9571 to add support for other in-memory formats for the RHS of joins, but that shouldn't block here as it wasn't existing functionality.

This LGTM!

@cpcloud cpcloud added this to the 9.2 milestone Jul 13, 2024
@cpcloud cpcloud force-pushed the pyarrow-optional branch from 74b1221 to 7be1302 Compare July 13, 2024 22:02
@cpcloud cpcloud force-pushed the pyarrow-optional branch from 7be1302 to dbd80c3 Compare July 13, 2024 22:02
@cpcloud
Copy link
Member Author

cpcloud commented Jul 14, 2024

Clouds are passing:

cloud in 🌐 falcon in …/ibis on  pyarrow-optional is 📦 v9.1.0 via 🐍 v3.10.14 via ❄️   impure (ibis-3.10.14-env) took 43s
❯ pytest -m bigquery --dist loadgroup -q -n auto --snapshot-update && pytest -m snowflake --dist loadgroup -q -n 8                      
bringing up nodes...
x...x...x.....x................x.s.....x...........x..s..s.................x...............................x................................s........................ [  8%]
x......x...xx...........x...xx......x..x...x.............xx..xxx.x.....x.....x.x...x......x................x........................x.x.....x.....x.................. [ 16%]
..................x........sssssssssssssssssssss...x...................................x..........x.......................sssssssssssssssssssssssssss......x......... [ 24%]
.x..................x.......x.......x..........x....x...x..x...........xx..x......xx..x...............x...x....x........xxxx.............x...xx........x..x.......xx. [ 33%]
...x....................x....xxx.................x........x.............x......................xxx...x....xxx..x.......x......................x.x...x.x.x..x......... [ 41%]
..........x.......x.........x.x..x..x...x......x.......x................x..x.s........x....x....x.......x..x.s..........x......sx....x..x.x............x......x...... [ 49%]
........x...x..x.xx....x............s..........x.....xx.....x..x..x.x....x............x........x.....xx..x.x....x.x.x.......x............x.xx.x.xxx.xxxx..x.xxx..x..x [ 58%]
.x.xxxxxxxx..x....x.xxxx.xxxxxxxxxxxxxx.xxxxx.xxx.xxxxxx.xxxxxxxxxxxxxx.xxxxxx.xxxxxx..xxxxxxx...xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx..x.xxxxx.x.x..x.xxxxxx...x.xxxxxx [ 66%]
x..x.xx..x.x.xx....x...x......x..x..x..x.xx..xx.........x.......xx..x...x...........x.x...x..................x..........................x..xx..x.x.x.x...........x... [ 74%]
..x...............x.x....x.......x................................................................................................................................... [ 82%]
...................x................................................................................................................................................. [ 91%]
.........................................................................x........................x...x....................x.x.x.x...x................................ [ 99%]
.......                                                                                                                                                               [100%]
1596 passed, 56 skipped, 336 xfailed in 228.35s (0:03:48)
bringing up nodes...
x...........x...........x...xxx.x.......x....x..x.x........x..x.x.x...................x.......x..x...x...x.x..x.........x....xx.xxx.......x........x.............x.... [  9%]
xx.xxxx.x........xxx.xxxx.........x...............x...............x...................x..............................x..x.......x.....x.........x.............x...... [ 18%]
...x.....x...x.x...x.x.....x........x................x..................x..x......xx.............xx.................................xs..
............................. [ 28%]
x....x......................x....x.xx.xxx.....x.....x.........xx...x..........x....x............x.....x......x...xx.x........x....x......x............x.............. [ 37%]
..............x........x.........x......xx........................................................................xx....................x...x........................ [ 46%]
..........................x.............x.s..........x........................x.....x..........x.x...x......................x.....x...x.............................. [ 56%]
.................................x..........x.........x.s.......x............xx..x.....x.......x.x.xx....xxxxxx...x.x.xxx..xxx..x.xx.xx.xx..x.x...xx...x....x.x..xx.x [ 65%]
.x..xxx..xx..xx.xxxx.x..x..xxx..x...x...x.xx.xxx....sx...x.....................x.......................s.....................s..x....x..............x..x.x.xxx.x.x... [ 74%]
........x...............x...............x........x................x.........x.x...x...x...........................x.x.x.x........x.x..x..x.......x................x.. [ 84%]
...........x.........x.............x.....................x..x......................................................................................................... [ 93%]
...........s........................................................s..............s....................s...........             [100%]
1536 passed, 10 skipped, 222 xfailed in 175.59s (0:02:55)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants