Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle): avoid double cursor closing by removing unnecessary close in _fetch_from_cursor #9913

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 25, 2024

Previously we were trying to close a cursor after an exception was raised in raw_sql, which already closes the cursor in the case of an exception. This is not allowed by the oracledb driver, so just close the cursor on success.

@cpcloud cpcloud added this to the 9.4 milestone Aug 25, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests oracle The Oracle backend labels Aug 25, 2024
@cpcloud cpcloud requested a review from gforsyth August 26, 2024 12:13
@cpcloud cpcloud force-pushed the unhide-oracle-hidden-exceptions branch from 2090491 to 524237c Compare August 26, 2024 12:41
@cpcloud cpcloud force-pushed the unhide-oracle-hidden-exceptions branch from 524237c to f4c65e8 Compare August 26, 2024 12:41
@cpcloud cpcloud changed the title fix(oracle): only close the cursor in _safe_raw_sql when raw_sql succeeds fix(oracle): avoid double cursor closing by removing unnecessary close in _fetch_from_cursor Aug 26, 2024
@gforsyth gforsyth merged commit a402095 into ibis-project:main Aug 26, 2024
82 checks passed
@cpcloud cpcloud deleted the unhide-oracle-hidden-exceptions branch August 26, 2024 15:57
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Aug 26, 2024
…se` in `_fetch_from_cursor` (ibis-project#9913)

Previously we were trying to close a cursor after an exception was
raised in `raw_sql`, which already closes the cursor in the case of an
exception. This is not allowed by the oracledb driver, so just close the
cursor on success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis oracle The Oracle backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants