-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comments): add "Disqus_click_to_load" to improve in-GFW-users #182
Conversation
Well,I personally think we needn't that button.This theme is face to users from the whole world.Not all the countries have the same Internet problem like China.So I think we need a way to judge whether the vistor can load Disqus or not,then automaticlly decide if it is nesscary to load Disqus. |
@neoFelhz Oh. As that we face to the whole world users, we need to consider users' local net situation. Personally,I think we should give the right to the user, Let them could choose if they need to turn it on. |
…utton and fix the text in the button
@neoFelhz Multilingual support for the button is added, also the text updated |
@viosey Multilingual support for the button is added, also the text is updated |
@cubesky No. |
Contributing rules
canary
. Then be sure to put thecanary
branch as the target for your pull request.Contributing rules
part from this descriptionWhat kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
English:
Add a way to load Disqus comments:“Dissqus_click_to_load”. It means that Disqus will be load after your click. Useful as it is, it help improve experience of Chinese who are trapped by the GFW so that avoid progress bar pause.
The style of “Read Comments” button is based on Material Design, Click-effect will be added next release
Thanks to button's js git: https://github.com/davinder17s/material-ripple-effect
Add multilingual support for the button and fix the text in the button: "Read Comments 「Be sure 'disq.us & disquscdn.com & disqus.com' can be loaded 」" (IN dbef40c )
中文:
增加一种Disqus的手动加载方式,点击后加载Disqus评论。对墙内用户更加友好,避免有部分浏览器加载卡进度条(如Via,Chrome等浏览器)
采用MD风格的”阅读评论“ button
button的JS引用自: https://github.com/davinder17s/material-ripple-effect
增加了手动加载button的文字提示:“阅读评论 「请确保 disq.us & disquscdn.com & disqus.com 可以正常加载」”,并加入多语言支持 (在 dbef40c 中)
Verification steps
/material/_config.yml
. Input below atLine 170
to turn on.hexo g
,you will see the different