Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented build process fails for vault plugin with current golang 1.15 #4

Closed
priyanknarvekar opened this issue Nov 30, 2020 · 5 comments

Comments

@priyanknarvekar
Copy link

It appears that as of golang 1.15, the arch support for darwin/386 was removed (golang/go#37610)

Documentation does not indicate the golang version it has been tested with.

We need to document the golang version that the code and build process has been tested with and/or update the build scripts to not build for arch darwin/386

@smatzek
Copy link
Contributor

smatzek commented Nov 30, 2020

In my testing I used Go 1.14.2 and Vault 1.5.0.

The build scripts match what is in the GCP and Azure plugins, which do contain "darwin/386". The build process used to build Vault, which pulls in the plugins and builds them is setting up the arch differently than how it defaults when called by make.

I can recreate this problem at Go 1.15.5. To build this with Go 1.15.5, remove "darwin/386" from
https://github.com/ibm-cloud-security/vault-plugin-secrets-ibmcloud/blob/main/scripts/build.sh#L26

@smatzek
Copy link
Contributor

smatzek commented Nov 30, 2020

Another, simpler workaround is to run make dev which will build the binary for your local architecture and will skip all of the others, including the problematic darwin/386 arch.

@priyanknarvekar
Copy link
Author

@smatzek , understand gcp/azure still have it in their scripts and understand the workaround, thats what we have used it for now.
intention of this issue was to either

  • get the build.sh updated based on go version and/OR
  • get our Readme.md updated as a known issue and Go version supported
    we need to atleast update our Readme and document the Go version

@smatzek
Copy link
Contributor

smatzek commented Nov 30, 2020

@priyanknarvekar Above I was documenting workarounds and versions I used during dev/test so that others that hit the same issue know their options while we work on the fix and test it. I agree that a fix to the README and build scripts is needed which is why I did not close the issue after commenting above.

@smatzek
Copy link
Contributor

smatzek commented Dec 15, 2020

Fix by #6

@smatzek smatzek closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants