Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow key navigation broken in Firefox #433

Closed
kgibb opened this issue Nov 16, 2015 · 3 comments
Closed

Arrow key navigation broken in Firefox #433

kgibb opened this issue Nov 16, 2015 · 3 comments
Assignees
@wkeese
Milestone
0.8.1

Comments

@kgibb
Copy link
Contributor

kgibb commented Nov 16, 2015

KeyNav no longer works with Firefox. The KeyboardEvent.key value returned for the left arrow key is "ArrowLeft", not "Left".

Tested with FF 42.0
@wkeese
Copy link
Member

wkeese commented Nov 17, 2015

Hmm, you are right. Also, key navigation in deliteful's Combobox, Slider and StarRating widgets is broken too.

The Event.key spec was changed in w3c/uievents@430c958 (for bug https://www.w3.org/Bugs/Public/show_bug.cgi?id=22084) to use "ArrowLeft", "ArrowDown" etc. rather than "Left" and "Down", and now browsers are just starting to catch up.

So, the issue is in the delite/on polyfill code. I could temporarily map "ArrowLeft" to "Left", for backwards compatibility, but eventually it's better for delite/on to polyfill to the spec, mapping "Left" to "ArrowLeft", and then update client code (delite/KeyNav, deliteful/Combobox, deliteful/Slider, deliteful/StarRating, etc.) to use the official strings of "ArrowLeft" etc.

wkeese added a commit to wkeese/delite that referenced this issue Nov 18, 2015
@wkeese
Make Event.key report "ArrowLeft" etc. not "Left", to match spec change
2ffdf52 
in https://www.w3.org/Bugs/Public/show_bug.cgi?id=22084.

Fixes arrow key navigation in latest Firefox.

Fixes ibm-js#433.
@wkeese wkeese closed this as completed in 8e59b9f Nov 19, 2015
@wkeese wkeese self-assigned this Nov 19, 2015
@wkeese wkeese added this to the 0.8.0 milestone Nov 19, 2015
wkeese added a commit to ibm-js/deliteful that referenced this issue Nov 19, 2015
@wkeese
upgrade to use "ArrowLeft" etc. not "Left", refs ibm-js/delite#433
baf74b1
@clmath
Copy link
Member

clmath commented Nov 19, 2015

Shouldn't that be in 0.8.1 ?

@wkeese
Copy link
Member

wkeese commented Nov 19, 2015

Yes, it's in 0.8.1, but there's no milestone setting for 0.8.1. Does it matter?

@clmath clmath modified the milestones: 0.8.1, 0.8.0 Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkeese wkeese

Labels
None yet
Projects
None yet
Milestone
0.8.1
Development

No branches or pull requests
3 participants
@wkeese @clmath @kgibb