Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: zero width when used in popup on IE11 #590

Closed
wkeese opened this issue Feb 10, 2016 · 0 comments
Closed

List: zero width when used in popup on IE11 #590

wkeese opened this issue Feb 10, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@wkeese
Copy link
Member

wkeese commented Feb 10, 2016

When a List is displayed as a popup on IE11, the width becomes essentially zero (or 16px). You can see this by modifying any List sample to be inside of a <div style="position: absolute: left: 50px; top: 50px">.

The IE11 problem is triggered by the extra layer of nesting in the ListItem elements, specifically the <div class="d-list-cell"> inside the <d-list-item-renderer class="d-list-item">, both of which are display:flex:

<d-list-item-renderer class="d-list-item">
    <div class="d-list-cell">
        <div class="d-list-item-icon {{item.iconclass}}" aria-hidden="true" role="presentation"></div>
        <div class="d-list-item-label">short</div>
        <div class="d-spacer"></div>
        <div class="d-list-item-right-text"></div>
        <div class="d-list-item-right-icon {{item.righticonclass}}" aria-hidden="true" role="presentation">&gt;</div>
    </div>
</d-list-item-renderer>

If I change the <d-list-item-renderer class="d-list-item"> to display:block, then the list renders correctly on IE11. From my limited testing it doesn't seem to break anything. I don't understand though why we have separate <d-list-item-renderer class="d-list-item"> and <div class="d-list-cell"> nodes. (Note: maybe need similar changes for d-list-category etc.?)

Originally filed as ibm-js/delite#422 but I think it needs to be fixed (worked around) in the deliteful/List code rather than in delite/popup.

@wkeese wkeese self-assigned this Feb 19, 2016
@wkeese wkeese added this to the 0.8.2 milestone Feb 19, 2016
@wkeese wkeese added the bug label Feb 24, 2016
@wkeese wkeese closed this as completed in fd4e26c Mar 8, 2016
wkeese added a commit that referenced this issue Mar 8, 2016
Fixes problem with lists in popups on IE11.
Fixes #590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant