Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in ViewStack #593

Closed
kgibb opened this issue Feb 15, 2016 · 1 comment
Closed

Memory leak in ViewStack #593

kgibb opened this issue Feb 15, 2016 · 1 comment
Assignees
@wkeese
Labels
bug
Milestone
0.8.2

Comments

@kgibb
Copy link

kgibb commented Feb 15, 2016

When the selected child is removed from the ViewStack, the _visibleChild property still references the detached node.

The _visibleChild property isn't nullified/re-assigned until (and if) show is called again.

We're dynamically showing/hiding nodes and there are instances where the view stack can be empty.

Perhaps ViewStack should do a superCall on Container.removeChild or listen for delite-remove-child and nullify _visibleChild if needed.
@wkeese wkeese added this to the 0.8.2 milestone Mar 6, 2016
@wkeese wkeese self-assigned this Mar 6, 2016
@wkeese wkeese added the bug label Mar 6, 2016
@wkeese
Copy link
Member

wkeese commented Mar 6, 2016

Sure, makes sense.

@wkeese wkeese closed this as completed in 84bad2b Mar 7, 2016
wkeese added a commit that referenced this issue Mar 8, 2016
@wkeese
clear this_visibleChild on removeChild(), fixes #593
af8d757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkeese wkeese

Labels
bug
Projects
None yet
Milestone
0.8.2
Development

No branches or pull requests
2 participants
@wkeese @kgibb