Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: support role=menu #604

Closed
wkeese opened this issue Mar 11, 2016 · 0 comments
Closed

List: support role=menu #604

wkeese opened this issue Mar 11, 2016 · 0 comments
Assignees
@wkeese
Labels
enhancement
Milestone
0.8.2

Comments

@wkeese
Copy link
Member

wkeese commented Mar 11, 2016

Currently only role=grid and role=listbox are supported.

It would also be nice to support [and default to] role=list, but that's a separate issue.
@wkeese wkeese self-assigned this Mar 11, 2016
@wkeese wkeese added this to the 0.8.2 milestone Mar 11, 2016
wkeese added a commit to wkeese/deliteful that referenced this issue Mar 11, 2016
@wkeese
Add List support for role=menu.
2cf45a4 
It works similarly to role=listbox.

Also refactor how Renderer roles are set by adding a Renderer#parentRole property.

Fixes ibm-js#604.
@wkeese wkeese closed this as completed in d2a1038 Mar 11, 2016
wkeese added a commit to wkeese/deliteful that referenced this issue Apr 4, 2016
@wkeese
More changes related to List support for role=menu.
b701186 
Change most of the role === "listbox" checks to role !== "grid".
Refs ibm-js#604.
wkeese added a commit to wkeese/deliteful that referenced this issue Apr 4, 2016
@wkeese
More changes related to List support for role=menu.
27d3d17 
Change most of the role === "listbox" checks to role !== "grid".
Refs ibm-js#604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkeese wkeese

Labels
enhancement
Projects
None yet
Milestone
0.8.2
Development

No branches or pull requests
2 participants
@wkeese and others