Skip to content

Commit

Permalink
[patch] Fix playbook defaults and suite_dns default handling (#1114)
Browse files Browse the repository at this point in the history
Co-authored-by: David Parker <parkerda@uk.ibm.com>
  • Loading branch information
andrercm and durera authored Nov 27, 2023
1 parent 9d798d2 commit 3f5a8c4
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions ibm/mas_devops/playbooks/oneclick_add_assist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
# Application Dependencies
cos_type: ibm
cpd_service_name: wd
cpd_product_version: "{{ lookup('env', 'CPD_PRODUCT_VERSION') | default('4.5.0', true) }}"
cpd_product_version: "{{ lookup('env', 'CPD_PRODUCT_VERSION') | default('4.6.6', true) }}"

# Application Installation
mas_app_id: assist
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.7.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.8.x', true) }}"

mas_app_spec:
bindings:
Expand Down
2 changes: 1 addition & 1 deletion ibm/mas_devops/playbooks/oneclick_add_iot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

# Application Installation
mas_app_id: iot
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.7.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.8.x', true) }}"

# Application Configuration
mas_workspace_id: "{{ lookup('env', 'MAS_WORKSPACE_ID') | default('masdev', true) }}"
Expand Down
2 changes: 1 addition & 1 deletion ibm/mas_devops/playbooks/oneclick_add_manage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# Application Installation
# mas_app_id can be set to "health" to install manage in the "Health standalone" mode from this same playbook.
mas_app_id: "{{ lookup('env', 'MAS_APP_ID') | default('manage', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.6.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.7.x', true) }}"

# Application Configuration
mas_workspace_id: "{{ lookup('env', 'MAS_WORKSPACE_ID') | default('masdev', true) }}"
Expand Down
2 changes: 1 addition & 1 deletion ibm/mas_devops/playbooks/oneclick_add_monitor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
vars:
# Application Installation
mas_app_id: monitor
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.10.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.11.x', true) }}"

# Application Configuration
mas_workspace_id: "{{ lookup('env', 'MAS_WORKSPACE_ID') | default('masdev', true) }}"
Expand Down
2 changes: 1 addition & 1 deletion ibm/mas_devops/playbooks/oneclick_add_optimizer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
vars:

# Application Installation
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.4.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.5.x', true) }}"
mas_app_id: optimizer

# Application Configuration
Expand Down
4 changes: 2 additions & 2 deletions ibm/mas_devops/playbooks/oneclick_add_predict.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@
# Application Installation
# -------------------------------------------------------------------------
mas_app_id: predict
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.8.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.9.x', true) }}"

# Application Configuration
# -------------------------------------------------------------------------
mas_workspace_id: "{{ lookup('env', 'MAS_WORKSPACE_ID') | default('masdev', true) }}"

# Cloud Pak for Data Configuration
# -------------------------------------------------------------------------
cpd_product_version: "{{ lookup('env', 'CPD_PRODUCT_VERSION') | default('4.5.0', true) }}"
cpd_product_version: "{{ lookup('env', 'CPD_PRODUCT_VERSION') | default('4.6.6', true) }}"

# these vars will be set by cp4d playbook, if it did not run (eg install_cp4d_platform=false), it will be set by the environment vars.
cpd_url: "{{ lookup('env', 'CPD_URL') }}"
Expand Down
2 changes: 1 addition & 1 deletion ibm/mas_devops/playbooks/oneclick_add_visualinspection.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# Application Installation
# mas_app_id can be set to "health" to install manage in the "Health standalone" mode from this same playbook.
mas_app_id: visualinspection
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.8.x', true) }}"
mas_app_channel: "{{ lookup('env', 'MAS_APP_CHANNEL') | default('8.9.x', true) }}"

# Application Configuration
mas_workspace_id: "{{ lookup('env', 'MAS_WORKSPACE_ID') | default('masdev', true) }}"
Expand Down
4 changes: 2 additions & 2 deletions ibm/mas_devops/roles/suite_certs/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
mas_instance_id: "{{ lookup('env', 'MAS_INSTANCE_ID') }}"
mas_config_dir: "{{ lookup('env', 'MAS_CONFIG_DIR') }}"
mas_suite_certs_dir: "{{ mas_config_dir }}/certs"
mas_manual_cert_mgmt: "{{ lookup('env', 'MAS_MANUAL_CERT_MGMT') | default(False, true) }}"
mas_manual_cert_mgmt: "{{ lookup('env', 'MAS_MANUAL_CERT_MGMT') | default(False, true) | bool }}"

# Optional parameters when using CIS as DNS Provider
dns_provider: "{{ lookup('env', 'DNS_PROVIDER') }}" # optional - works only if DNS provider is CIS
cis_crn: "{{ lookup('env', 'CIS_CRN') }}"
cis_apikey: "{{ lookup('env', 'CIS_APIKEY') }}"
cis_subdomain: "{{ lookup('env', 'CIS_SUBDOMAIN') }}"
cis_proxy: "{{ lookup('env', 'CIS_PROXY') | default('False', true) }}"
cis_proxy: "{{ lookup('env', 'CIS_PROXY') | default('False', true) | bool }}"
mas_workspace_id: "{{ lookup('env', 'MAS_WORKSPACE_ID') }}"

# All the TLS secret names across the suite. Currently there's no common naming convention we can use.
Expand Down

0 comments on commit 3f5a8c4

Please sign in to comment.