Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] fix default booleans for suite_dns #1590

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[patch] fix default booleans for suite_dns #1590

merged 3 commits into from
Dec 12, 2024

Conversation

leo-miran
Copy link
Contributor

Fixes issue with non boolean default values causing wrong assertions when running this role.

Before this fix when cis_enhanced_security was set to a string False value

TASK [ibm.mas_devops.suite_dns : cis : running standard cis suite dns] *********
skipping: [localhost] => changed=false 
  false_condition: not cis_enhanced_security
  skip_reason: Conditional result was `False`

After fix:

TASK [ibm.mas_devops.suite_dns : cis : running standard cis suite dns] *********
included: /opt/app-root/lib64/python3.9/site-packages/ansible_collections/ibm/mas_devops/roles/suite_dns/tasks/providers/cis/cis_suitedns_basic.yml for localhost

@leo-miran leo-miran marked this pull request as draft December 11, 2024 18:15
@leo-miran leo-miran marked this pull request as ready for review December 12, 2024 11:39
@durera durera added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 79c5991 Dec 12, 2024
2 checks passed
@durera durera deleted the cissuer branch December 12, 2024 16:28
karol-czarnecki added a commit that referenced this pull request Dec 16, 2024
@karol-czarnecki
Squashed commit of the following:
057f830 
commit 49b2099
Author: Rawa <61942902+rawa-resul@users.noreply.github.com>
Date:   Thu Dec 12 16:28:49 2024 +0000

    [patch] Fix subscription lookup in upgrade (#1589)

    Co-authored-by: Rawa Resul <rawa.resul@ibm.com>

commit 79c5991
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Thu Dec 12 13:26:06 2024 -0300

    [patch] fix default booleans for suite_dns (#1590)

commit 1e91ba5
Author: Andrew Whitfield <whitfiea@uk.ibm.com>
Date:   Thu Dec 12 07:34:31 2024 +0000

    [patch] Increase rosa deprovision wait time (#1592)
karol-czarnecki added a commit that referenced this pull request Dec 19, 2024
@karol-czarnecki
Squashed commit of the following:
ef5b38c 
commit 13770e9
Author: sekharcvalluri <54737838+sekharcvalluri@users.noreply.github.com>
Date:   Thu Dec 19 19:19:48 2024 +0530

    [patch] Fix cos_bucket picking incorrect resourcegroup (#1593)

    Co-authored-by: Harsh Tamakuwala <Harsh.Tamakuwala@ibm.com>
    Co-authored-by: leo-miran <105313348+leo-miran@users.noreply.github.com>

commit 0a3b97b
Author: David Parker <parkerda@uk.ibm.com>
Date:   Thu Dec 19 13:47:57 2024 +0000

    [major] Replace ICSP with IDMS (#1594)

commit b08cda4
Author: Harsh Tamakuwala <31183552+harsh42774@users.noreply.github.com>
Date:   Thu Dec 19 18:49:47 2024 +0530

    [patch] Update supported kafka versions (#1608)

    Co-authored-by: Harsh Tamakuwala <Harsh.Tamakuwala@ibm.com>

commit cf05717
Author: David Parker <parkerda@uk.ibm.com>
Date:   Thu Dec 19 11:39:55 2024 +0000

    [patch] Lock mas-devops less than v2 (#1607)

commit 6ff397e
Author: David Parker <parkerda@uk.ibm.com>
Date:   Tue Dec 17 22:35:41 2024 +0000

    [patch] Enable HMAC by default for IBM COS (#1606)

commit 49b2099
Author: Rawa <61942902+rawa-resul@users.noreply.github.com>
Date:   Thu Dec 12 16:28:49 2024 +0000

    [patch] Fix subscription lookup in upgrade (#1589)

    Co-authored-by: Rawa Resul <rawa.resul@ibm.com>

commit 79c5991
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Thu Dec 12 13:26:06 2024 -0300

    [patch] fix default booleans for suite_dns (#1590)

commit 1e91ba5
Author: Andrew Whitfield <whitfiea@uk.ibm.com>
Date:   Thu Dec 12 07:34:31 2024 +0000

    [patch] Increase rosa deprovision wait time (#1592)

commit 91bd67b
Author: Ian Boden <82514609+IanBoden@users.noreply.github.com>
Date:   Mon Dec 9 10:32:54 2024 +0000

    [patch] reinstate zenmetastore and couchdb workarounds for cpd 4.8 (#1580)

commit aa05d8a
Author: Rawa <61942902+rawa-resul@users.noreply.github.com>
Date:   Fri Dec 6 16:32:24 2024 +0000

    [patch] Fix label_selectors pattern (#1586)

    Co-authored-by: Rawa Resul <rawa.resul@ibm.com>

commit e0ba0de
Author: Parveen Kumar <parveenkumar@ibm.com>
Date:   Fri Dec 6 19:23:46 2024 +0530

    [minor] Support December catalog (#1562)

    Co-authored-by: Anil Prajapati <Anil.Prajapati@ibm.com>
    Co-authored-by: Jon Levell <jonquark@users.noreply.github.com>
    Co-authored-by: Jon Levell <levell@uk.ibm.com>
    Co-authored-by: Ian Boden <82514609+IanBoden@users.noreply.github.com>
    Co-authored-by: Ian Boden <ianboden@uk.ibm.com>
    Co-authored-by: Anil Prajapati <169060963+anilprajapatiibm@users.noreply.github.com>
    Co-authored-by: Terence Quinn <quinnt@us.ibm.com>
    Co-authored-by: David Parker <parkerda@uk.ibm.com>
    Co-authored-by: Rawa Resul <rawa.resul@ibm.com>
    Co-authored-by: Rawa <61942902+rawa-resul@users.noreply.github.com>

commit 9206656
Author: David Parker <parkerda@uk.ibm.com>
Date:   Tue Dec 3 14:36:31 2024 +0000

    [major] Use new OLM functions in mas-devops (#1573)

commit 3ccdbef
Author: Harsh Tamakuwala <31183552+harsh42774@users.noreply.github.com>
Date:   Mon Dec 2 18:30:04 2024 +0530

    [patch] Fixes ibmcloud_api_key issue in COS deprovision for ibmcloud (#1581)

    Co-authored-by: Harsh Tamakuwala <Harsh.Tamakuwala@ibm.com>

commit 1283c03
Author: Terence Quinn <quinnt@us.ibm.com>
Date:   Fri Nov 29 03:52:51 2024 -0600

    [patch] create unique certificate for each db2 instance (#1579)

commit e04138a
Author: David Parker <parkerda@uk.ibm.com>
Date:   Tue Nov 26 21:40:39 2024 +0000

    [patch] get_default_storage_classes should always set failed=False (#1578)

commit 7014f49
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Tue Nov 26 16:32:42 2024 +0000

    [patch]  Add estimates for cpd in readme (#1577)

commit 9933bc2
Author: David Parker <parkerda@uk.ibm.com>
Date:   Tue Nov 26 13:46:05 2024 +0000

    [patch] Use correct variable for mongo extras (#1576)

commit bb720a3
Author: David Parker <parkerda@uk.ibm.com>
Date:   Tue Nov 26 13:32:30 2024 +0000

    [patch] Set cpd_product_version  from catalog metadata (#1575)

commit ba23e83
Author: Terence Quinn <quinnt@us.ibm.com>
Date:   Mon Nov 25 15:03:03 2024 -0600

    [patch] Fix missing catalog_digest (#1574)

    Co-authored-by: David Parker <parkerda@uk.ibm.com>

commit 0f60c61
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Fri Nov 22 17:33:20 2024 +0000

    [patch] Add back restore.yml.j2 (#1572)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit 739c4d0
Author: David Parker <parkerda@uk.ibm.com>
Date:   Fri Nov 22 16:02:24 2024 +0000

    [major] Overhaul backup/restore capability (#1557)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit d5ef410
Author: David Parker <parkerda@uk.ibm.com>
Date:   Fri Nov 22 12:39:48 2024 +0000

    [doc] Fix formatting

commit 61272c9
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Fri Nov 22 12:27:00 2024 +0000

    [patch] fix restore for manage role (#1571)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit 0a13abd
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Thu Nov 21 10:40:05 2024 +0000

    [patch] Db2 backup/restore: fix copy local to pod script (#1569)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit f474509
Author: David Parker <parkerda@uk.ibm.com>
Date:   Wed Nov 20 23:43:25 2024 +0000

    [major] Move catalog & storage class metadata to python package (#1561)

commit df4fe4c
Author: Lokesh <110647904+lokesh-sreedhara@users.noreply.github.com>
Date:   Wed Nov 20 08:49:28 2024 -0500

    [patch] remove MIRRORLOGPATH folder creation  (#1568)

commit 5668f33
Author: Lokesh <110647904+lokesh-sreedhara@users.noreply.github.com>
Date:   Wed Nov 20 07:49:43 2024 -0500

    [patch] fix conflicting DB config (#1567)

commit 5c595c1
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Tue Nov 19 17:45:03 2024 +0000

    [patch] can skip db2 in br_manage playbook (#1566)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit 8c8f993
Author: stonepd <stonepd@uk.ibm.com>
Date:   Tue Nov 19 16:39:18 2024 +0000

    [patch] update CP4D README, remove outdated fix code (#1565)

    Co-authored-by: Sanjay Prabhakar <sanju7216@gmail.com>

commit 5eb2cd4
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Tue Nov 19 14:42:36 2024 +0000

    [patch] fix restore for core and fix tar command in restore tasks  (#1564)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit e81d3a3
Author: dclain <dclain@us.ibm.com>
Date:   Sat Nov 16 15:39:54 2024 -0600

    [patch] Address several issues w/ Nvidia playbook (#1558)

commit 1792e98
Author: Tremaine Hart <twhart@us.ibm.com>
Date:   Thu Nov 14 13:19:26 2024 -0600

    [patch] Fixes and updates for IBMCloud COS support (#1555)

    Co-authored-by: David Parker <parkerda@uk.ibm.com>

commit 495e26d
Author: Daniel Istrate <16302386+istrate@users.noreply.github.com>
Date:   Thu Nov 14 13:02:17 2024 +0200

    [doc] Document storage class access mode (#1554)

    Co-authored-by: Daniel Istrate <Daniel.Istrate1@ibm.com>

commit 08c22d7
Author: Anil Prajapati <169060963+anilprajapatiibm@users.noreply.github.com>
Date:   Tue Nov 12 02:51:17 2024 +0530

    [minor] Support November catalog (#1508)

    Co-authored-by: Parveen Kumar <parveenkumar@ibm.com>
    Co-authored-by: Jon Levell <jonquark@users.noreply.github.com>
    Co-authored-by: Jon Levell <levell@uk.ibm.com>
    Co-authored-by: Ian Boden <82514609+IanBoden@users.noreply.github.com>
    Co-authored-by: Ian Boden <ianboden@uk.ibm.com>

commit 3501786
Author: bmoferrall <44264093+bmoferrall@users.noreply.github.com>
Date:   Thu Nov 7 09:53:24 2024 -0800

    [patch] MAXMIS-897: check if attribute 'deployimagestitching' is defined (#1551)

    Co-authored-by: Brendan More O'Ferrall <mooreof@ie.ibm.com>

commit 00c50f1
Author: caemar <44871769+caemar@users.noreply.github.com>
Date:   Thu Nov 7 11:47:38 2024 +0100

    [minor] Add Kafka Cluster CA certificate validityDays (#1543)

commit ee3a227
Author: bmoferrall <44264093+bmoferrall@users.noreply.github.com>
Date:   Wed Nov 6 11:57:00 2024 -0800

    [patch] MAXMIS-886: disable stitching deploy when civil is not enabled2 (#1548)

    Co-authored-by: Brendan More O'Ferrall <mooreof@ie.ibm.com>

commit 3ee2512
Author: Tremaine Hart <twhart@us.ibm.com>
Date:   Wed Nov 6 11:41:34 2024 -0600

    [patch] [MASCORE-4344] Grafana role overwriting critical k8s configuration resource (#1549)

commit 482b386
Author: bmoferrall <44264093+bmoferrall@users.noreply.github.com>
Date:   Tue Nov 5 21:51:50 2024 -0800

    [minor] #MAXMIS-748: add role to auto configure image stitching (#1530)

    Co-authored-by: Brendan More O'Ferrall <mooreof@ie.ibm.com>
    Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com>
    Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>

commit dd13898
Author: Tremaine Hart <twhart@us.ibm.com>
Date:   Tue Nov 5 14:45:45 2024 -0600

    [patch] [MASCORE-4344] Grafana role overwriting critical k8s configuration resource (#1547)

commit ade2a0e
Author: Andrew Whitfield <whitfiea@uk.ibm.com>
Date:   Tue Nov 5 17:18:24 2024 +0000

    [patch] wait for olm to update operatorcondition (#1545)

commit c267990
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Tue Nov 5 16:33:07 2024 +0000

    [patch] prevent mongo upgrade when featureCompatibilityVersion is not defined or set incorrectly (#1544)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit f4c04d5
Author: Ian Boden <82514609+IanBoden@users.noreply.github.com>
Date:   Tue Nov 5 11:21:08 2024 +0000

    [patch] Fix gpu-certified-operator default channel (#1542)

commit 733b595
Author: David Parker <parkerda@uk.ibm.com>
Date:   Mon Nov 4 15:49:12 2024 +0000

    [patch] Fix oc exec commands (#1541)

commit 224a9a8
Author: David Parker <parkerda@uk.ibm.com>
Date:   Thu Oct 31 18:10:39 2024 +0000

    [patch] Reduce useless logging (#1540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durera durera durera approved these changes

@JonahLuckett JonahLuckett Awaiting requested review from JonahLuckett JonahLuckett is a code owner

@andrercm andrercm Awaiting requested review from andrercm andrercm is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq is a code owner

@whitfiea whitfiea Awaiting requested review from whitfiea whitfiea is a code owner

@alequint alequint Awaiting requested review from alequint alequint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-miran @durera