-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Add support for various SLS configurations #1438
Draft
rawa-resul
wants to merge
55
commits into
master
Choose a base branch
from
sls-rr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SLS related changes
python/src/mas/cli/install/settings/additionalConfigs.py
leveraging theself.addFilesToSecret
functionmanualCertificates
function within ``python/src/mas/cli/install/settings/additionalConfigs.pyto also create the SLS certificates (currently ca.crt) and store it within the mounted
pipeline-certificates` secretslsSummary
function to display variables depending on what SLS config has been chosenSLSConfigValidator
,SLSInstanceSelectionValidator
, andNewNamespaceValidator
python/src/mas/cli/install/argParser.py
for external SLSpython/src/mas/cli/install/argBuilder.py
to show SLS params based on config chosenconfigSLS
asconfigDRO
. Visually no change though.Other changes
--image-pull-policy
arg is now also passed on to interactive mode. This will help with development work.argChecker.py
which now holds functions to verify parameters beyond what argparse is capable of doing. For example creating argument dependencies or mutual exclusions.isValidDir
function inargParser.py
ToDo's
Related PR's
Testing