Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Add support for various SLS configurations #1438

Draft
wants to merge 55 commits into
base: master
Choose a base branch
from
Draft

Conversation

rawa-resul
Copy link
Contributor

@rawa-resul rawa-resul commented Jan 12, 2025

Description

SLS related changes

  • Added new SLS flow
    • Simplified
      • No 'ibm-sls' on cluster or differently namespaced ones: Same as usual, you are prompted for a license and SLS will be installed in 'ibm-sls' ns
      • 'ibm-sls' ns found: You are prompted if you want to upload a new license
    • Advanced
      • New
        • You can install a new SLS instance and are prompted for namespace
      • Existing
        • This option is only shown if we find SLS instances on the cluster.
        • After choosing an instance you are prompted if you want to replace the license file
      • External
        • You provide the sls_url, sls_registration_key and path to dir containing the ca.crt
        • Then a quick request is performed on the readiness endpoint
        • If check was 200 all good nothing will be shown, otherwise you are prompted if you want to proceed despite an unhealthy check
  • License file secret is now created in the CLI within python/src/mas/cli/install/settings/additionalConfigs.py leveraging the self.addFilesToSecret function
  • Extended the manualCertificates function within ``python/src/mas/cli/install/settings/additionalConfigs.pyto also create the SLS certificates (currently ca.crt) and store it within the mountedpipeline-certificates` secret
  • Improved the slsSummary function to display variables depending on what SLS config has been chosen
  • Added three new Validators: SLSConfigValidator, SLSInstanceSelectionValidator, and NewNamespaceValidator
  • Added new params under python/src/mas/cli/install/argParser.py for external SLS
  • Updated python/src/mas/cli/install/argBuilder.py to show SLS params based on config chosen
  • Added/updated SLS parameters under various tekton yamls
  • Separated out the DRO prompts within the configSLS as configDRO. Visually no change though.

Other changes

  • --image-pull-policy arg is now also passed on to interactive mode. This will help with development work.
  • Added argChecker.py which now holds functions to verify parameters beyond what argparse is capable of doing. For example creating argument dependencies or mutual exclusions.
  • Added isValidDir function in argParser.py

ToDo's

  • Update docs
  • Lots of testing

Related PR's

Testing

  • In progress ...

@rawa-resul rawa-resul self-assigned this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant