Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] SNO Support #1447

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

[minor] SNO Support #1447

wants to merge 9 commits into from

Conversation

alequint
Copy link
Contributor

@alequint alequint commented Jan 25, 2025 •
edited
Loading

As part of this PR we:

  • update provision aws command line to support sno settings. When SNO is enabled, two variables are modified accordingly such as IPI_COMPUTE_REPLICA and IPI_CONTROLPLANE_REPLICAS. These variables are not explicitly informed in command line, that is why we need to know the intention to provision single node in AWS, so based on that we know what to set
  • in addition, knowing the intention we want to create a single node cluster in AWS, we can also set ephemeral storage accordingly, addressing issue Expose IPI_ROOTVOLUME_SIZE input in CLI when configuring SNO clusters in AWS #1439

Test is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unnati-solanki-git unnati-solanki-git Awaiting requested review from unnati-solanki-git

@durera durera Awaiting requested review from durera durera will be requested when the pull request is marked ready for review durera is a code owner

@JonahLuckett JonahLuckett Awaiting requested review from JonahLuckett JonahLuckett will be requested when the pull request is marked ready for review JonahLuckett is a code owner

@andrercm andrercm Awaiting requested review from andrercm andrercm will be requested when the pull request is marked ready for review andrercm is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab will be requested when the pull request is marked ready for review sanjayprab is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq will be requested when the pull request is marked ready for review terenceq is a code owner

@whitfiea whitfiea Awaiting requested review from whitfiea whitfiea will be requested when the pull request is marked ready for review whitfiea is a code owner

@leo-miran leo-miran Awaiting requested review from leo-miran leo-miran will be requested when the pull request is marked ready for review leo-miran is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alequint @unnati-solanki-git