Skip to content

Conversation

@zigarn
Copy link

@zigarn zigarn commented Mar 15, 2025

The Ingress for webconsole has no reason to target the NodePort service of the webconsole, which is not necessarily enabled.
Instead, just target the ClusterIP service, which is always deployed.

Also use port name instead of port number.
And fix indentation consistency.

@zigarn zigarn changed the title Fix webconsole ingress Fix webconsole Ingress Mar 15, 2025
@callumpjackson
Copy link
Collaborator

Thanks for making the above pull request. Please indicate in the Pull Request that you accept and agree to be bound by the terms of the Developer's Certificate of Origin.
We can then evaluate the above as part of a future release.

@zigarn
Copy link
Author

zigarn commented Mar 17, 2025

I do accept and agree the terms of the Developer's Certificate of Origin.
Here is the signature of the document with the second key from https://github.com/zigarn.keys:

-----BEGIN SSH SIGNATURE-----
U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgkLkGTich4gGAdLFaFBPiOHn+SI
TPtMZ0wuBIgIMNVrIAAAAEZmlsZQAAAAAAAAAGc2hhNTEyAAAAUwAAAAtzc2gtZWQyNTUx
OQAAAEC5B6gFQt96ujfumyc92KbAvCZMzeF5dMICrFvGWQ05k7mqmKFWtjRR1/Fw9d36Ci
6ry+NoPE5wiJIo0dFQJN4F
-----END SSH SIGNATURE-----

@callumpjackson
Copy link
Collaborator

Fixed as part of #118 - thanks for submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants