Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ClearAll message in Deconfig records #340

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Updated ClearAll message in Deconfig records #340

merged 1 commit into from
Apr 7, 2025

Conversation

Nikhil-Ashoka
Copy link
Collaborator

@Nikhil-Ashoka Nikhil-Ashoka commented Jan 8, 2025 •
edited
Loading

@Nikhil-Ashoka Nikhil-Ashoka self-assigned this Jan 8, 2025
@Nikhil-Ashoka Nikhil-Ashoka marked this pull request as draft January 8, 2025 13:51
@Nikhil-Ashoka
Copy link
Collaborator Author

Future implementation: https://jsw.ibm.com/browse/PFEBMC-4053

@Nikhil-Ashoka Nikhil-Ashoka reopened this Mar 14, 2025
@Nikhil-Ashoka Nikhil-Ashoka marked this pull request as ready for review March 14, 2025 07:17
@Nikhil-Ashoka
Copy link
Collaborator Author

Screenshot 2025-03-14 at 1 51 03 PM Screenshot 2025-03-14 at 1 51 52 PM

@vedangimittal
Copy link

Can we update the error toast to include a message informing the user know that they can delete the record individually?

@Nikhil-Ashoka
Copy link
Collaborator Author

Can we update the error toast to include a message informing the user know that they can delete the record individually?

That is a good point, I have started a multi-chat and added you there... Based on the response, we can take action...

@Nikhil-Ashoka
Updated ClearAll message in Deconfig records
339f55a 
- Clear All API will always give success, In 1110, Manual Cores and system guard records are not cleared.
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=671125

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
@rfrandse rfrandse merged commit 561f2ab into ibm-openbmc:1110 Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabilpandiyalayil nabilpandiyalayil nabilpandiyalayil approved these changes

@vedangimittal vedangimittal vedangimittal approved these changes

Assignees

@Nikhil-Ashoka Nikhil-Ashoka

Labels
1110
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nikhil-Ashoka @vedangimittal @nabilpandiyalayil @rfrandse