Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Profile settings page #384

Open
wants to merge 1 commit into
base: 1110-vue3
Choose a base branch
from

Conversation

vedangimittal
Copy link

@vedangimittal vedangimittal changed the title Implemendted Profile settings page Implemented Profile settings page Mar 3, 2025
@vedangimittal vedangimittal marked this pull request as draft March 3, 2025 05:54
@vedangimittal vedangimittal self-assigned this Mar 3, 2025
@vedangimittal vedangimittal marked this pull request as ready for review March 10, 2025 09:53
Copy link
Collaborator

@Nikhil-Ashoka Nikhil-Ashoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-19 at 10 34 36 AM

I see some issues:

  1. Hide and show of password fields are not working.
  2. Validation: Error messages are not showing up.
  3. Alignment issues with the info message numbering.
  4. Form is not submitting for user even when password and confirm password is same.

- Implemented Profile setings page
- Jira story: https://jsw.ibm.com/browse/PFEBMC-2384

Signed-off-by: Vedangi Mittal <vedangimittal3004@gmail.com>
</b-col>
</b-row>
</BCol>
</BRow>

<b-form @submit.prevent="submitForm">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use BForm here

</BFormRadio>
</BFormGroup>
</BCol>
</BRow>
</page-section>
<b-button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use BButton

Copy link
Collaborator

@Nikhil-Ashoka Nikhil-Ashoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of code updates needed, Functionality looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants