Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc changes for secret manager support #141

Closed
wants to merge 2 commits into from

Conversation

BShrivastav
Copy link
Collaborator

Added doc changes for secret manager support

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-22777

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Added doc changes for secret manager support
- `crn` - (String) The CRN for this certificate instance.

-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certificate Manager is deprecated. Migrate your load balancer certificates from Certificate Manager to Secrets Manager.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified.

- `crn` - (String) The CRN for this certificate instance.

-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certificate Manager is deprecated. Migrate your load balancer certificates from Certificate Manager to Secrets Manager.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified.

@@ -33,6 +33,9 @@ In addition to all argument references listed, you can access the following attr
- `certificate_instance` - (List) The certificate instance used for SSL termination. It is applicable only to `https`protocol.
Nested scheme for `certificate_instance`:
- `crn` - (String) The CRN for this certificate instance.

-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager because the certificate CRN from Certificate Manager is deprecated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@@ -33,6 +33,9 @@ In addition to all argument references listed, you can access the following attr
- `certificate_instance` - (List) The certificate instance used for SSL termination. It is applicable only to `https`protocol.
Nested scheme for `certificate_instance`:
- `crn` - (String) The CRN for this certificate instance.

-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager because the certificate CRN from Certificate Manager is deprecated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@@ -187,6 +187,9 @@ Review the argument references that you can specify for your resource.
- Have the same protocol as this listener, or have a compatible protocol. At present, the compatible protocols are http and https.
- Not already be the default_pool for another listener
- `certificate_instance` - (Optional, String) The CRN of the certificate instance, it is applicable(mandatory) only to https protocol.

-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@@ -187,6 +187,9 @@ Review the argument references that you can specify for your resource.
- Have the same protocol as this listener, or have a compatible protocol. At present, the compatible protocols are http and https.
- Not already be the default_pool for another listener
- `certificate_instance` - (Optional, String) The CRN of the certificate instance, it is applicable(mandatory) only to https protocol.

-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@BShrivastav
Copy link
Collaborator Author

closing post approval raised upstream PR: IBM-Cloud#3872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants