-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added doc changes for secret manager support #141
Conversation
Added doc changes for secret manager support
- `crn` - (String) The CRN for this certificate instance. | ||
|
||
-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certificate Manager is deprecated. Migrate your load balancer certificates from Certificate Manager to Secrets Manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified.
- `crn` - (String) The CRN for this certificate instance. | ||
|
||
-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certificate Manager is deprecated. Migrate your load balancer certificates from Certificate Manager to Secrets Manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified.
@@ -33,6 +33,9 @@ In addition to all argument references listed, you can access the following attr | |||
- `certificate_instance` - (List) The certificate instance used for SSL termination. It is applicable only to `https`protocol. | |||
Nested scheme for `certificate_instance`: | |||
- `crn` - (String) The CRN for this certificate instance. | |||
|
|||
-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager because the certificate CRN from Certificate Manager is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
@@ -33,6 +33,9 @@ In addition to all argument references listed, you can access the following attr | |||
- `certificate_instance` - (List) The certificate instance used for SSL termination. It is applicable only to `https`protocol. | |||
Nested scheme for `certificate_instance`: | |||
- `crn` - (String) The CRN for this certificate instance. | |||
|
|||
-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager because the certificate CRN from Certificate Manager is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
@@ -187,6 +187,9 @@ Review the argument references that you can specify for your resource. | |||
- Have the same protocol as this listener, or have a compatible protocol. At present, the compatible protocols are http and https. | |||
- Not already be the default_pool for another listener | |||
- `certificate_instance` - (Optional, String) The CRN of the certificate instance, it is applicable(mandatory) only to https protocol. | |||
|
|||
-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
@@ -187,6 +187,9 @@ Review the argument references that you can specify for your resource. | |||
- Have the same protocol as this listener, or have a compatible protocol. At present, the compatible protocols are http and https. | |||
- Not already be the default_pool for another listener | |||
- `certificate_instance` - (Optional, String) The CRN of the certificate instance, it is applicable(mandatory) only to https protocol. | |||
|
|||
-> **NOTE:** Migrate your load balancer certificates from Certificate Manager to Secrets Manager as the certificate CRN from Certificate Manager is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
closing post approval raised upstream PR: IBM-Cloud#3872 |
Added doc changes for secret manager support
Community Note
Relates OR Closes #0000
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-22777
Output from acceptance testing: