Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 - Vni phase 2 CRUD, floating ip, reserved ip, flow logs #278

Merged
merged 148 commits into from
Jan 11, 2024
Merged

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Jul 7, 2023

Changes in datasource :

  • virtual_network_interface

    • code
    • test
    • doc
  • virtual_network_interface_floating_ip

    • code
    • test
    • doc
  • virtual_network_interface_floating_ips

    • code
    • test
    • doc
  • virtual_network_interface_ip

    • code
    • test
    • doc
  • virtual_network_interface_ips

    • code
    • test
    • doc
  • virtual_network_interfaces

    • code
    • test
    • doc

Changes in resource :

  • flow_log

    • code
    • test
    • doc
  • security_group

    • code
    • test
    • doc
  • subnet_reserved_ip

    • code
    • test
    • doc
  • virtual_network_interface

    • code
    • test
    • doc
  • virtual_network_interface_floating_ip

    • code
    • test
    • doc
  • virtual_network_interface_ip

    • code
    • test
    • doc

[] Develop resource/commands for VNI CRUD apis
[] Develop VNI floating ips CRUD apis
[] Develop VNI reserved ips CRUD apis
[] Revisit VNI prototype and add additional properties to the schema/commands
[] Develop secondary ips in file share mount target
[] develop vni ID and auto_delete in mount target


Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMIsVirtualNetworkInterfaceBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceBasic (141.15s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     143.277s
...
=== RUN   TestAccIBMIsVirtualNetworkInterfaceIPBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceIPBasic (142.16s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     144.214s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceFloatingIPBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceFloatingIPBasic (164.57s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     166.874s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceFloatingIPsDataSourceBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceFloatingIPsDataSourceBasic (166.14s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     168.242s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceFloatingIPDataSourceBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceFloatingIPDataSourceBasic (165.28s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     167.334s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceIpDataSourceBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceIpDataSourceBasic (153.44s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     155.622s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceIpsDataSourceBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceIpsDataSourceBasic (147.24s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     149.332s
=== RUN   TestAccIBMISFlowLog_vni
--- PASS: TestAccIBMISFlowLog_vni (159.36s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     161.166s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceDataSourceVniBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfaceDataSourceVniBasic (46.92s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     49.156s
=== RUN   TestAccIBMIsVirtualNetworkInterfacesDataSourceVniBasic
--- PASS: TestAccIBMIsVirtualNetworkInterfacesDataSourceVniBasic (42.89s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     44.980s
=== RUN   TestAccIBMIsVirtualNetworkInterfaceAllArgs
--- PASS: TestAccIBMIsVirtualNetworkInterfaceAllArgs (250.12s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     252.792s

@ujjwal-ibm ujjwal-ibm changed the title Vnip2 Vni phase 2 Jul 7, 2023
@astha-jain
Copy link
Collaborator

astha-jain commented Sep 27, 2023

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/data-sources/is_virtual_network_interface - Is missing attributes like enable_infrastructure_nat, ips, mac_address and allow_ip_spoofing. Please add.

@astha-jain
Copy link
Collaborator

@astha-jain
Copy link
Collaborator

astha-jain commented Sep 27, 2023

datasource for reserved ips - Should be covered in this PR Right?

[vni-crud-branch][parent branch vni-1]
Generate SDK and keep it updated

  • Develop resource/commands for VNI CRUD apis
  • Develop VNI floating ips CRUD apis
  • Develop VNI reserved ips CRUD apis
  • Revisit VNI prototype and add additional properties to the schema/commands
  • Develop secondary ips in file share mount target
  • develop vni ID and auto_delete in mount target

michaelkad and others added 28 commits December 18, 2023 08:08
* Add Deprectated for VPN Create

* Update text

* Update version to 1.5.6

* Update version to 1.5.6

* update power version

---------

Co-authored-by: michael kad <michaelkad>
* feature(share-crr): Share cross region replication

* sdk updates

* updated last sync options

* updated sdk and latest_sync

* updated schema and doc

* tf example

* doc and schema correction

* acceptance test

* sdk changes

* updated sdk

* added nil check

* doc link added

* remove common folder sdk

* doc update
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](golang/crypto@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…ces (IBM-Cloud#4998)

* Enhancement: Added operating system attributes to is images data sources

* set the values

* test and doc changes
)

* new version

* new version

* new version

* update code to the latest SDK level

* fix integration tests

* fix integration tests

* fix integration tests

* fix integration tests

* address PR comment

* typo

* typo

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* add wait for create and delete

* add wait for create and delete

* .

* fix integration tests

* fix integration tests

* fix integration tests

* fix integration tests

* fix integration tests

* regenerate

* new code generation

* new generated code

* point to latest sdk

* point to latest sdk

* adjust test cases and doc

* adjust samples

* update to latest node sdk

* merge with master

* Update project_instance.html.markdown

Fixing formatting issues

* Update project_event_notification.html.markdown

* Update README.md

* Update variables.tf

* Update project_event_notification.html.markdown

* new version

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* terraform

* feat: projects graph fragment pattern

* align with origin/master

* update test cases

* restore README.md and versions.tf to master branch

* remove duplicated entries

* feat: graph fragment pattern poc

* feat: restore definition blocks

* regenerate the terraform code based on latest YAML

* regenerate the terraform code based on latest YAML

* regenerate the terraform code based on latest YAML

* update doc

* update doc

* fix test cases

* commit generated code

* commit fix

* commit fix

* test cases

* test cases

* test cases

* test cases

* updates

* upgrade to latest go sdk

* update generated doc

* update generated code

* updated secrets baseline

* update code to latest API changes

* secrets

* fix secrets

* update samples with real values

* update secrets

* update secrets

* update generated code to the latest API definition

* update secrets baseline

* merge with master

* merge with master

* merge with master

* update code to the latest SDK level

* address some review comments

* address PR comments

* address PR comments

* update to latest sdk level

* update to latest sdk level

* update to latest sdk level

* merge with master

* update to the latest sdk level

* format test case

* regenerate the code with generator fixes

* regenerate code

* fix "inputs" and "settings" properties

* regenerated doc and samples

* fix samples

* terraform

* terraform

* terraform

* terraform

* terraform

---------

Co-authored-by: dvesperini <dvesperini@gmail.com>
Co-authored-by: knee-na <130502432+knee-na@users.noreply.github.com>
Co-authored-by: Mark-Kulube <markkulube@ibm.com>
…Cloud#5005)

* added advertised route support

* doc updates for routing table/s

* Change advertise_routes_to from List to HashSet and modify create, update and read methods accordingly

* Add latest generated go sdk

* update with latest sdk

* add beta maturity to sdk

* corrected docs as per review comment

* updated go mod

* Update resource_ibm_is_bare_metal_server.go

* rm common

---------

Co-authored-by: Bhavesh Shrivastav <bhavesh.shrivastav@ibm.com>
Co-authored-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com>
* SC addition

* SC addition

* SC addition

* update function updated

* SC unit tests added

* SC unit tests added

* d

* tests fixes

* tests fixes

* update sdk

* .secrets.baseline update

* .secrets.baseline update

* .secrets.baseline update

* Update sm_service_credentials_secret_metadata.html.markdown

* bugs fixes

* bugs fixes

* bugs fixes

---------

Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com>
Co-authored-by: Avi Ribchinsky <avir@il.ibm.com>
Co-authored-by: Tatyana <tatyanab@il.ibm.com>
Co-authored-by: Idan Adar <iadar@il.ibm.com>
Bumps [crazy-max/ghaction-import-gpg](https://github.com/crazy-max/ghaction-import-gpg) from 6.0.0 to 6.1.0.
- [Release notes](https://github.com/crazy-max/ghaction-import-gpg/releases)
- [Commits](crazy-max/ghaction-import-gpg@v6.0.0...v6.1.0)

---
updated-dependencies:
- dependency-name: crazy-max/ghaction-import-gpg
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
* fix: multipart fix for mqcloud

(cherry picked from commit e7253421db30943d3582ce07d9504a2117f30ce1)

* enable enforceReservedDeploymentPlan

---------

Co-authored-by: Shuaib Bapputty <shuaib.bapputty@ibm.com>
* SC addition

* SC addition

* SC addition

* update function updated

* SC unit tests added

* SC unit tests added

* d

* tests fixes

* tests fixes

* update sdk

* .secrets.baseline update

* .secrets.baseline update

* .secrets.baseline update

* Update sm_service_credentials_secret_metadata.html.markdown

* bugs fixes

* bugs fixes

* bugs fixes

* docs bugs fixes

---------

Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com>
Co-authored-by: Avi Ribchinsky <avir@il.ibm.com>
Co-authored-by: Tatyana <tatyanab@il.ibm.com>
Co-authored-by: Idan Adar <iadar@il.ibm.com>
Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7.
- [Release notes](https://github.com/cloudflare/circl/releases)
- [Commits](cloudflare/circl@v1.3.3...v1.3.7)

---
updated-dependencies:
- dependency-name: github.com/cloudflare/circl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
There a bug with the MTU field in terraform where ExactlyOneOf
requires Jumbo or MTU to be set, but the intent was to allow
at most one of those fields to be set, but are optional.
@ujjwal-ibm ujjwal-ibm merged commit 2900aac into vnip2-sdk Jan 11, 2024
@ujjwal-ibm ujjwal-ibm deleted the vnip2 branch March 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.