Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multi Volume Snapshots and Backup #294

Closed

Conversation

SunithaGudisagarIBM1
Copy link
Collaborator

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 commented Sep 29, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsSnapshotConsistencyGroupsDataSourceBasic'

...
Screenshot 2023-10-12 at 3 49 37 PM Screenshot 2023-10-12 at 3 50 04 PM Screenshot 2023-10-16 at 2 29 19 PM

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the feature-is-snapshot-consistency-group branch from b36707d to 0175371 Compare October 3, 2023 04:02
@SunithaGudisagarIBM1
Copy link
Collaborator Author

	data "ibm_is_snapshot" "ds_snapshot" {
		name 		= "sunitha-snapshot"
	}
Screenshot 2023-10-03 at 12 19 15 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

SunithaGudisagarIBM1 commented Oct 3, 2023

resource "ibm_is_snapshot_consistency_group" "is_snapshot_consistency_group_instance" {
  delete_snapshots_on_delete = true
  snapshots {
    name = "sunitha-snapshot"
    source_volume = "r134-03276451-ecee-4d82-851f-a388cc8629fd"
  }
  snapshots {
    name = "sunitha-snapshot-1"
    source_volume = "r134-fb1349f1-6e4a-4477-839d-c2054563e47b"
  }
  name = "sunitha-snapshot-consistency-group1"
}

data "ibm_is_snapshot_consistency_group" "is_snapshot_consistency_group_instance" {
  identifier = ibm_is_snapshot_consistency_group.is_snapshot_consistency_group_instance.id
    /* name = "sunitha-snapshot-consistency-group1" */
 } 
 data "ibm_is_snapshot_consistency_groups" "is_snapshot_consistency_group_instance" {
  depends_on = [ibm_is_snapshot_consistency_group.is_snapshot_consistency_group_instance]
  name = "sunitha-snapshot-consistency-group1"
}

data "ibm_is_snapshot" "ds_snapshot" {
   name 		= "sunitha-snapshot"
   depends_on = [ibm_is_snapshot_consistency_group.is_snapshot_consistency_group_instance]
}
Screenshot 2023-10-03 at 12 54 14 PM Screenshot 2023-10-03 at 12 54 45 PM Screenshot 2023-10-03 at 12 55 07 PM Screenshot 2023-10-03 at 12 55 19 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

data "ibm_is_snapshots" "ds_snapshots" {
  snapshot_consistency_group_id = "r134-9150ff57-60dd-41b8-9c67-0821140b0f5d"
  depends_on                    = [ibm_is_snapshot_consistency_group.is_snapshot_consistency_group_instance]
}

@SunithaGudisagarIBM1
Copy link
Collaborator Author

Screenshot 2023-10-03 at 2 05 11 PM

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the feature-is-snapshot-consistency-group branch from 26e14f8 to 9d26ff2 Compare October 3, 2023 12:54
@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the feature-is-snapshot-consistency-group branch from 9d26ff2 to 66b1397 Compare October 3, 2023 15:53
@SunithaGudisagarIBM1 SunithaGudisagarIBM1 marked this pull request as ready for review October 4, 2023 06:36
@SunithaGudisagarIBM1
Copy link
Collaborator Author

export IBMCLOUD_IS_NG_API_ENDPOINT=https://us-south-genesis-dal12-mzr-integ2.iaasdev.cloud.ibm.com/v1

resource "ibm_is_backup_policy" "is_backup_policy" {
  match_user_tags = ["tag-0"]
  name            = "sunitha-terraform-baas"
  match_resource_type = "instance"
}
data "ibm_is_backup_policies" "is_backup_policies" {
  depends_on  = [ibm_is_backup_policy.is_backup_policy]
}
Screenshot 2023-10-10 at 8 43 11 PM

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the feature-is-snapshot-consistency-group branch 3 times, most recently from 38f8af4 to b8576f9 Compare October 12, 2023 13:36
@SunithaGudisagarIBM1
Copy link
Collaborator Author

Testing in Staging:

resource "ibm_is_backup_policy" "is_backup_policy" {
  match_user_tags = ["tag-0"]
  name            = "sunitha-terraform-baas"
  match_resource_type = "instance"
}

resource "ibm_is_backup_policy" "is_backup_policy1" {
  match_user_tags = ["tag-0"] 
  match_resource_types = ["volume"]
  name            = "sunitha-terraform-baas1" 
} 
data "ibm_is_backup_policies" "is_backup_policies" {
  depends_on  = [ibm_is_backup_policy.is_backup_policy]
}

data "ibm_is_backup_policy" "is_backup_policy" {
  identifier =  ibm_is_backup_policy.is_backup_policy.id
} 
Screenshot 2023-10-25 at 3 51 47 PM Screenshot 2023-10-25 at 3 51 40 PM Screenshot 2023-10-25 at 3 52 00 PM Screenshot 2023-10-25 at 3 52 17 PM

@sumitkumartiwari sumitkumartiwari changed the title Feature is snapshot consistency group Feature: Multi Volume Snapshots and Backup Nov 15, 2023
Copy link
Collaborator

@sumitkumartiwari sumitkumartiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add acceptance test for changes in backup creation, snapshot filters, and job filters.

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the feature-is-snapshot-consistency-group branch from 72ff617 to 1ab89d7 Compare December 6, 2023 17:44
@SunithaGudisagarIBM1 SunithaGudisagarIBM1 deleted the feature-is-snapshot-consistency-group branch December 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants