Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] group_keys in groupby #705

Merged
merged 5 commits into from
Jan 14, 2025
Merged

[patch] group_keys in groupby #705

merged 5 commits into from
Jan 14, 2025

Conversation

pkohlmann
Copy link
Contributor

@pkohlmann pkohlmann self-assigned this Jan 9, 2025
sedgewickmm18
sedgewickmm18 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@sedgewickmm18 sedgewickmm18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code modifications

  • to replace the outdated least_square (ls) with squared_error
  • to explicitly drop the index component for entities we group 'over' in groupby and
  • to shuffle droplevel() calls occasionally to adjust to the now explicit behavior of groupby
    look good to me. Ready for pandas 1.5 and 2.*

@pkohlmann pkohlmann merged commit ac4d89c into master Jan 14, 2025
1 check failed
@pkohlmann pkohlmann deleted the kohlmann-master-removeif branch January 14, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedgewickmm18 sedgewickmm18 sedgewickmm18 approved these changes

@rsivaibm rsivaibm Awaiting requested review from rsivaibm rsivaibm is a code owner

@herleraja herleraja Awaiting requested review from herleraja herleraja is a code owner

Assignees

@pkohlmann pkohlmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkohlmann @sedgewickmm18