Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting sdk_resource as customized for runAqaTest #108

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

julian55455
Copy link

@julian55455 julian55455 commented Oct 18, 2022

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,18"

Copy link

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should merge it after the release.

@smlambert
Copy link

Yes we are in a code freeze right now so this will not get merged for a bit. @julian55455 you can still mark it as a Outreachy contribution despite the delay to merge it.

@sophia-guo
Copy link

sophia-guo commented Oct 19, 2022

This PR is dependent PR of adoptium/aqa-tests#2097, which will not fix adoptium/aqa-tests#2097. Might be better to update the description to related instead of fix adoptium/aqa-tests#2097 @julian55455

@llxia
Copy link

llxia commented Nov 2, 2022

@julian55455 could you please update the description as suggested in #108 (comment)? Thanks

@AdamBrousseau
Copy link

Is there a reason why we aren't delivering this upstream to the main Adopt repo?

@llxia
Copy link

llxia commented Nov 2, 2022

Adopt uses upstream as they use staged SDK on Jenkins. Semeru pipeline uses customized (SDK URL from artifactory). This is a special case for Semeru.

@AdamBrousseau
Copy link

Got it, thanks.

@llxia
Copy link

llxia commented Nov 7, 2022

@AdamBrousseau could you please review this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting CUSTOMIZED_SDK_URL and SDK_RESOURCE as non-customized ignores the SDK_RESOURCE value
5 participants