-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting sdk_resource as customized for runAqaTest #108
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we should merge it after the release.
Yes we are in a code freeze right now so this will not get merged for a bit. @julian55455 you can still mark it as a Outreachy contribution despite the delay to merge it. |
This PR is dependent PR of adoptium/aqa-tests#2097, which will not fix adoptium/aqa-tests#2097. Might be better to update the description to related instead of fix adoptium/aqa-tests#2097 @julian55455 |
@julian55455 could you please update the description as suggested in #108 (comment)? Thanks |
Is there a reason why we aren't delivering this upstream to the main Adopt repo? |
Adopt uses |
Got it, thanks. |
@AdamBrousseau could you please review this PR? Thanks |
Fixes adoptium/aqa-tests#2097
cc @llxia @sophia-guo @smlambert