Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: verify pointer before calling its method #2

Merged
merged 1 commit into from
Oct 1, 2020
Merged

src: verify pointer before calling its method #2

merged 1 commit into from
Oct 1, 2020

Commits on Sep 30, 2020

  1. src: verify pointer before calling its method 

    The destructor InstanceMethodCallBaton() calls m_javaObject->Unref()
which aborts when m_javaObject is NULL.

Affects at least `npm test` from `node-jdbc` npm, which aborts in
test `testcreatetable`:

(abort) [0x26C7C640]
(__cxa_end_catch) [0x2E2CC414]
(InstanceMethodCallBaton::~InstanceMethodCallBaton()+0x140) [0x2E2CD2A4]
(Nan::AsyncWorker::Destroy()@AF61_58+0x28) [0x2E2CCE4C]
(Nan::AsyncWorker::Destroy()+0x18) [0x2E2C9F12]
(Nan::AsyncExecuteComplete(uv_work_s*)+0x4e) [0x27DB5430]
...
    @gabylb
    gabylb committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    34bb02c View commit details
    Browse the repository at this point in the history