GetCallerClassTest: Accept OpenJ9's InternalError Message #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
changed the title
babsingh
force-pushed
the
fix_GetCallerClassTest
branch
from
4c194d9
to
5b12b46
Compare
babsingh
changed the title
|
While testing these changes locally, I noticed segfaults in the JVM, which was built using the latest openjdk-next, openj9 and omr repos. These test changes won't cause the segfault. Just to be safe, I will keep this PR in the draft state until I figure out the cause of the segfaults,. |
|
You could just use |
babsingh
force-pushed
the
fix_GetCallerClassTest
branch
3 times, most recently
from
0c945e9
to
50e72a6
Compare
InternalError message in GetCallerClassTest differs between JVMs: - OpenJ9: "Caller is not annotated as @sun.reflect.CallerSensitive" - OpenJDK: "CallerSensitive annotation expected" GetCallerClassTest has been updated to accept OpenJ9's InternalError message. Closes: eclipse-openj9/openj9#13998 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_GetCallerClassTest
branch
from
50e72a6
to
28eb9f8
Compare
Updated the PR to reflect the suggested changes. |
|
lgtm. Regardless of the segfaults, if this is removed from draft then I would merge it. |
|
The segfault is a new failure, which is observed later in the test code after this fix is applied. I have opened eclipse-openj9/openj9#14097 to investigate the segfault. This PR should be good to merge. |
pshipton
approved these changes
Dec 7, 2021
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 13, 2021
eclipse-openj9/openj9#13996 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13997 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13998 is fixed via ibmruntimes/openj9-openjdk-jdk#382. GetCallerClassTest does not run successfully yet. Currently, it fails due to eclipse-openj9/openj9#14097. So, it remains excluded. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 13, 2021
eclipse-openj9/openj9#13996 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13997 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13998 is fixed via ibmruntimes/openj9-openjdk-jdk#382. GetCallerClassTest continues to be excluded since it fails due to eclipse-openj9/openj9#14097. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 15, 2021
eclipse-openj9/openj9#13996 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13997 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13998 is fixed via ibmruntimes/openj9-openjdk-jdk#382. GetCallerClassTest continues to be excluded since it fails due to eclipse-openj9/openj9#14097. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Dec 15, 2021
eclipse-openj9/openj9#13996 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13997 is fixed via eclipse-openj9/openj9#14125. eclipse-openj9/openj9#13998 is fixed via ibmruntimes/openj9-openjdk-jdk#382. GetCallerClassTest continues to be excluded since it fails due to eclipse-openj9/openj9#14097. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InternalError message in GetCallerClassTest differs between JVMs:
GetCallerClassTest has been updated to accept OpenJ9's InternalError message.
Closes: eclipse-openj9/openj9#13998
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com