Support exporting plain SecretKey in FIPS mode #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilburZjh
force-pushed
the
exportSecretKey
branch
from
ee88299
to
58a6007
Compare
|
Hi @keithc-ca , please help to review FYI @jasonkatonica |
keithc-ca
reviewed
Jun 27, 2023
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java
Outdated
Show resolved
Hide resolved
keithc-ca
requested changes
Jun 27, 2023
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
Outdated
Show resolved
Hide resolved
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
Outdated
Show resolved
Hide resolved
|
In your commit message, the Signed-off-by line should be the last line. |
WilburZjh
force-pushed
the
exportSecretKey
branch
2 times, most recently
from
42b83fb
to
1618589
Compare
We support exporting and importing plain RSA/EC private keys and importing secret keys as AES in FIPS mode for now. We also need to support exporting secret keys in FIPS mode. Currently, while user generating an AES secretkey in FIPS mode through KeyGenerator, this AES key's encode is NULL. Therefore, we modify the P11Key.java and SunPKCS11.java files to enable the support for exporting secret keys inclusing AES and TripleDES. Signed-off-by: Jinhang Zhang <Jinhang.Zhang@ibm.com>
WilburZjh
force-pushed
the
exportSecretKey
branch
from
1618589
to
3b86658
Compare
|
Jenkins test sanity.openjdk alinux64 jdknext |
keithc-ca
approved these changes
Jun 28, 2023
This was referenced Jul 10, 2023
tajila
pushed a commit
to tajila/openj9-openjdk-jdk
that referenced
this pull request
Mar 27, 2024
Fix the PKCS11Exception: CKR_KEY_TYPE_INCONSISTENT in FIPS mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinhang Zhang Jinhang.Zhang@ibm.com
We support exporting and importing plain
RSA/EC private keys and importing secret
keys as AES in FIPS mode for now. We also
need to support exporting secret keys in
FIPS mode. Currently, while user generating
an AES secretkey in FIPS mode through
KeyGenerator, this AES key's encode is NULL.
Therefore, we modify the P11Key.java and
SunPKCS11.java files to enable the support
for exporting secret keys inclusing AES
and TripleDES.