Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Update Harfbuzz to 7.0.1 #237

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Revert Update Harfbuzz to 7.0.1 #237

merged 3 commits into from
Jul 13, 2023

Conversation

pshipton
Copy link
Member

@keithc-ca
Copy link
Member

I think this is missing 5ca81bc (#191).

@pshipton
Copy link
Member Author

5ca81bc is already in the v0.40.0-release branch.

@pshipton
Copy link
Member Author

Keith said, you can see the changes are missing when comparing against the 0.38 release branch. I cherry picked the change and added it.

@keithc-ca
Copy link
Member

Jenkins compile aix jdk17 depends eclipse-openj9/openj9#v0.40.0-release eclipse-openj9/openj9-omr#v0.40.0-release

@keithc-ca
Copy link
Member

The build failed with the all too frequent "Sjavac server failed to initialize: Deadlock condition if locked" problem.

@pshipton
Copy link
Member Author

jdk_imageio testing https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/2585/

@pshipton
Copy link
Member Author

pshipton commented Jul 13, 2023 •
edited
Loading

p8-java1-ibm07
There is a failure with javax/imageio/plugins/shared/ImageWriterCompressionTest.java

17:44:14  java.lang.Error: Probable fatal error: No physical fonts found.
17:44:14  	at java.desktop/sun.font.SunFontManager.lambda$getDefaultPhysicalFont$0(SunFontManager.java:1056)

Not sure if it's a result of this change, it may be this change has exposed the failure since it couldn't run before.

@pshipton
Copy link
Member Author

pshipton commented Jul 13, 2023 •
edited
Loading

It may just be a machine issue, we don't normally run these tests on these machines. I'll try the test internally.

@pshipton
Copy link
Member Author

pshipton commented Jul 13, 2023 •
edited
Loading

The first iteration passed internally, I think the OpenJ9 machines don't have the fonts installed.

@keithc-ca keithc-ca merged commit 2f3d502 into ibmruntimes:v0.40.0-release Jul 13, 2023
@keithc-ca keithc-ca mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pshipton @keithc-ca