Update ignore list based on M2 build #178
Conversation
JinhangZhang
force-pushed
the
m2
branch
3 times, most recently
from
87cb0a7
to
3716cae
Compare
JinhangZhang
force-pushed
the
m2
branch
2 times, most recently
from
4523fe2
to
6d7f7ab
Compare
JinhangZhang
force-pushed
the
m2
branch
2 times, most recently
from
07db030
to
d1f363d
Compare
|
@keithc-ca could you pls review? |
| sun/security/ssl/SSLContextImpl/SSLContextDefault.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 linux-x64,linux-ppc64le,linux-s390x,aix-all |
There was a problem hiding this comment.
Normally I would ask that the list of platforms be ordered alphabetically (aix-all,linux-ppc64le,linux-s390x,linux-x64), but to avoid delaying the 0.46.0 release further I won't insist this time.
There was a problem hiding this comment.
Also, the issues referenced here should have some content that helps explain why a given test is excluded: #153 is just empty. Can we do better?
There was a problem hiding this comment.
I suggest this change be proposed (as is) for the 0.46.0 release branch and then this can be improved as I suggested above.
There was a problem hiding this comment.
Souds good, @keithc-ca could you approve/merge?
Normally I would ask that the list of platforms be ordered alphabetically (aix-all,linux-ppc64le,linux-s390x,linux-x64), but to avoid delaying the 0.46.0 release further I won't insist this time.
FYI @JinhangZhang
There was a problem hiding this comment.
Also, the issues referenced here should have some content that helps explain why a given test is excluded: #153 is just empty. Can we do better?
We do have a plan to analyze all of them in the future not only for 21 but also for all other versions as well.
There was a problem hiding this comment.
I suggest this change be proposed (as is) for the 0.46.0 release branch and then this can be improved as I suggested above.
sorted
There was a problem hiding this comment.
Also, the issues referenced here should have some content that helps explain why a given test is excluded: #153 is just empty. Can we do better?
FYI @JinhangZhang
| sun/security/rsa/TestSigGen15.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x,linux-x64 | ||
| sun/security/rsa/TestSignatures.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x,linux-x64 | ||
| sun/security/rsa/WithoutNULL.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x,linux-x64 | ||
| sun/security/r |
There was a problem hiding this comment.
s390x should appear before x86.
JinhangZhang
force-pushed
the
m2
branch
2 times, most recently
from
b76b844
to
42fb643
Compare
| jdk/security/logging/RecursiveEventHelper.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x | ||
| jdk/nio/zipfs/ZipFSTester.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x | ||
| sun/security/pkcs11/SecretKeyFactory/TestPBKD.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x,linux-x64 | ||
| sun/security/ssl/SSLContextImpl/SSLContextDefault.java https://github.com/ibmruntimes/openj9-openjdk-jdk21/issues/153 aix-all,linux-ppc64le,linux-s390x,linux-x64 |
There was a problem hiding this comment.
I'll approve this, but in the future, tests should be sorted alphabetically (at least within a group - "jdk/nio" should appear before "jdk/security").
No description provided.