[FFI/Jtreg_JDK21] Adjust the padding bytes of struct on AIX #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned at eclipse-openj9/openj9#18287 (comment), the padding of the failing struct is 3 bytes on AIX. Note: the test suite can't be verified until everything related to eclipse-openj9/openj9#18287 is resolved. |
|
Reviewer: @keithc-ca |
keithc-ca
requested changes
Oct 18, 2023
The changes reflect the actual padding bytes of the failing test structs support double on AIX. Related: #eclipse-openj9/openj9/issues/18287 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_jtreg_fix_struct_padding_aix_jdk21
branch
from
6d4bb29 to
3d70baf
Compare
|
Please create a similar change for https://github.com/ibmruntimes/openj9-openjdk-jdk, which should be merged before this. |
The PR is created at ibmruntimes/openj9-openjdk-jdk#677. |
keithc-ca
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes reflect the actual padding bytes of
the failing test structs support double on AIX.
Related: #eclipse-openj9/openj9/issues/18287
Signed-off-by: ChengJin01 jincheng@ca.ibm.com