Fix the J9JDK_EXT_VERSION and remove obsolete JDK_MOD_VERSION #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Aug 17, 2022
ibmruntimes#532 modified the J9JDK_EXT_VERSION to use JDK_UPDATE_VERSION instead of JDK_MOD_VERSION, and COOKED_BUILD_NUMBER instead of JDK_FIX_VERSION. This obsoleted JDK_MOD_VERSION which can be removed. Using COOKED_BUILD_NUMBER in the J9JDK_EXT_VERSION is wrong, this is the IBM version for the extensions. The J9JDK_EXT_VERSION should end with .0 typically, and be modified any time there is a new extensions release for the same JDK_UPDATE_VERSION. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 17, 2022
Port of ibmruntimes#603 for 0.33.1, setting the JDK_FIX_VERSION to 1. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
keithc-ca
approved these changes
Aug 17, 2022
|
jenkins test sanity zlinux jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#532 modified the
J9JDK_EXT_VERSION to use JDK_UPDATE_VERSION instead of JDK_MOD_VERSION,
and COOKED_BUILD_NUMBER instead of JDK_FIX_VERSION. This obsoleted
JDK_MOD_VERSION which can be removed. Using COOKED_BUILD_NUMBER in the
J9JDK_EXT_VERSION is wrong, this is the IBM version for the extensions.
The J9JDK_EXT_VERSION should end with .0 typically, and be modified any
time there is a new extensions release for the same JDK_UPDATE_VERSION.
Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com