Fix memory leaks related to openssl EC pathways #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is associated with the issue located at eclipse-openj9/openj9#16451 |
jasonkatonica
force-pushed
the
katonica/issue73or16451/ECmemoryleak
branch
2 times, most recently
from
b4a3040
to
6e0b0a3
Compare
This update fixes a few memory leaks associated with the creation of EC private and public keys. This openssl api BN_bn2bin described here: https://www.openssl.org/docs/man1.0.2/man3/BN_bin2bn.html This api states that a new BIGNUM is created if the last argument is null to the API. In our case the last argument is indeed null so we are leaking memory in the EC paths since we never free the big number returned. A cleanup goto was also added to simplify the code and ensure that all cleanup of allocated memory is done. We make explicit calls to then free all allocated memory in the cleanup. This is a cherry pick of: ibmruntimes/openj9-openjdk-jdk@969654a Signed-off-by: Jason Katonica katonica@us.ibm.com
jasonkatonica
force-pushed
the
katonica/issue73or16451/ECmemoryleak
branch
from
6e0b0a3
to
b259e4d
Compare
|
Updated the PR text and commit text to follow the 72 character boundary where possible. Since I cherry picked this from a merged commit, the author was listed as both Keith and Myself. I changed the author to only myself. |
|
Jenkins test sanity alinux64,win32 jdk8 |
keithc-ca
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes a few memory leaks associated with the creation of
EC private and public keys.
This openssl api BN_bn2bin described here:
https://www.openssl.org/docs/man1.0.2/man3/BN_bin2bn.html
This api states that a new BIGNUM is created if the last argument
is null to the API. In our case the last argument is indeed null
so we are leaking memory in the EC paths since we never free the big
number returned.
A cleanup goto was also added to simplify the code and ensure that
all cleanup of allocated memory is done. We make explicit calls
to then free all allocated memory in the cleanup.
This is a cherry pick of:
ibmruntimes/openj9-openjdk-jdk@969654a
Signed-off-by: Jason Katonica katonica@us.ibm.com