Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match RI behaviour for MethodHandles.unrelfect with OpenJDK MHs #715

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Match RI behaviour for MethodHandles.unrelfect with OpenJDK MHs #715

merged 1 commit into from
Dec 5, 2023

Commits on Dec 4, 2023

  1. Match RI behaviour for MethodHandles.unrelfect with OpenJDK MHs 

    This patch addresses eclipse-openj9/openj9#14985.
For MethodHandles to private interface methods, the RI erroneously
initializes the MethodHandle to have an InvokeInterface reference
kind, leading to an invoke-time AbstractMethodError throw.

As per the spec, OpenJ9 initializes MethodHandles to private interface
methods to have an InvokeSpecial reference kind which does not throw
the error.

This distinction causes a test failure for a test reported in
eclipse-openj9/openj9#14985. Though not-spec compliant, the test expects
an AbstractMethodError to be thrown to conform to the RI behaviour. For
OpenJ9 MHs, MethodHandles.unreflect identifies private interface methods
and installs an AbstractMethodError-thrower MH. This patch sets up a
similar mechanism for OpenJDK MHs by calling a MethodHandleResolver
method that installs the AbstractMethodError-thrower MH.

Issues: eclipse-openj9/openj9#14985
Signed-off-by: Nathan Henderson <nathan.henderson@ibm.com>
    @ThanHenderson
    ThanHenderson committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bda4427 View commit details
    Browse the repository at this point in the history