Merge "Avoid silencing ClassNotFoundException in FIPS mode" to 0.43 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking whether available services exist, if RestrictedSecurity is enabled, the class has to be loaded to check whether it extends the java.security.Provider class. If the class cannot be found, a ClassNotFoundException is thrown and caught without taking further action. That, however, goes against the expected behaviour. The service must appear as available, and only attempting to load should trigger a ClassNotFoundException, which will be transformed into a ServiceConfigurationError. This change tries to load the next service to check if it should be allowed based on RestrictedSecurity criteria. If that succeeds, the loaded class is saved to be used when trying to get it in nextService(). Otherwise, a boolean variable is set to signify an exception should be thrown. The process continues until an appropriate service is found or one is responsible for a ClassNotFoundException. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
Avoid silencing ClassNotFoundException in FIPS mode
JasonFengJ9
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.