Parse jar index when using SCC #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity,extended alinux jdk8 |
|
If a jarIndex exists, the JDK by default (i.e. SCC is off) uses the URLs in the JarIndex to search for resources, the class path in manifest is ignored. However, when SCC is on, the jarIndex is always ignored and the class path in manifest is used, which differs from the default JDK behavior. Change SCC code in URLClassPath to always use URLs in jarIndex if it exists. Add a property "com.ibm.oti.shared.disableJarIndex" that can be used to control the behavior. JarIndex is removed in Java 21, no need to port to Java 21+. Internal issue semeru-runtimes/issues/1 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
|
jenkins test sanity,extended alinux jdk8 |
|
PR builds passed. |
pshipton
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a jarIndex exists, the JDK by default (i.e. SCC is off) uses the URLs in the JarIndex to search for resources, the class path in manifest is ignored.
However, when SCC is on, the jarIndex is always ignored and the class path in manifest is used, which differs from the default JDK behavior.
Change SCC code in URLClassPath to always use URLs in jarIndex if it exists.
Add a property "com.ibm.oti.shared.disableJarIndex" that can be used to control the behavior.
JarIndex is removed in Java 21, no need to port to Java 21+.
port of ibmruntimes/openj9-openjdk-jdk17#331
Internal issue semeru-runtimes/issues/1