Skip to content

Conversation

konflux-internal-p02[bot]
Copy link

@konflux-internal-p02 konflux-internal-p02 bot commented Jul 1, 2025

This PR contains the following updates:

Package Update Change
src/arrow digest 347a88f -> f7320c9

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from cf57bb9 to 7da07a7 Compare July 1, 2025 20:15
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 1202d79 chore(deps): update src/arrow digest to bf79398 Jul 1, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 7da07a7 to a06082e Compare July 8, 2025 08:52
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to bf79398 chore(deps): update src/arrow digest to f12356a Jul 8, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from a06082e to fe280ea Compare July 8, 2025 12:55
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to f12356a chore(deps): update src/arrow digest to 11c97b8 Jul 8, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from fe280ea to 4332bfe Compare July 8, 2025 20:16
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 11c97b8 chore(deps): update src/arrow digest to 5852134 Jul 8, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 4332bfe to 199fce6 Compare July 15, 2025 09:36
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 5852134 chore(deps): update src/arrow digest to 4605289 Jul 15, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 199fce6 to 077b738 Compare July 15, 2025 13:53
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 4605289 chore(deps): update src/arrow digest to d50e7e2 Jul 15, 2025
andrewschoen pushed a commit that referenced this pull request Jul 15, 2025
Previously, SyncPoint allocated two C_Gather instances tracked by raw
pointers but failed to properly clean them up when only a single sync
point existed, causing memory leaks detected by AddressSanitizer.

This change fixes the leak by modifying AbstractWriteLog::shut_down()
to check for prior sync points in the chain. When the current sync point
is the only one present, we now activate the m_prior_log_entries_persisted
context to ensure:

- The onfinish callback executes and releases the captured strong
  reference to the enclosing SyncPoint
- The parent m_sync_point_persist context completes and gets properly
  released

This ensures all allocated contexts are cleaned up correctly during
shutdown, eliminating the memory leak.

The ASan report:

```
Indirect leak of 2064 byte(s) in 1 object(s) allocated from:
    #0 0x56440919ae2d in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_librbd+0x2f3de2d) (BuildId: 6a04677c6ee5235f1a41815df807f97c5b96d4cd)
    #1 0x56440bd67751 in __gnu_cxx::new_allocator<Context*>::allocate(unsigned long, void const*) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0x56440bd676e0 in std::allocator<Context*>::allocate(unsigned long) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
    #3 0x56440bd676e0 in std::allocator_traits<std::allocator<Context*>>::allocate(std::allocator<Context*>&, unsigned long) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:464:20
    #4 0x56440bd6730b in std::_Vector_base<Context*, std::allocator<Context*>>::_M_allocate(unsigned long) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_vector.h:346:20
    #5 0x7fd33e00e8d1 in std::vector<Context*, std::allocator<Context*>>::reserve(unsigned long) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/vector.tcc:78:22
    #6 0x7fd33e00c51c in librbd::cache::pwl::SyncPoint::SyncPoint(unsigned long, ceph::common::CephContext*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/SyncPoint.cc:20:27
    #7 0x56440bd65f26 in decltype(::new((void*)(0)) librbd::cache::pwl::SyncPoint(std::declval<unsigned long&>(), std::declval<ceph::common::CephContext*&>())) std::construct_at<librbd::cache::pwl::SyncPoint, unsigned long&, ceph::common::CephContext*&>(librbd::cache::pwl::SyncPoint*, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_construct.h:97:39
    #8 0x56440bd65b98 in void std::allocator_traits<std::allocator<librbd::cache::pwl::SyncPoint>>::construct<librbd::cache::pwl::SyncPoint, unsigned long&, ceph::common::CephContext*&>(std::allocator<librbd::cache::pwl::SyncPoint>&, librbd::cache::pwl::SyncPoint*, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:518:4
    #9 0x56440bd657d3 in std::_Sp_counted_ptr_inplace<librbd::cache::pwl::SyncPoint, std::allocator<librbd::cache::pwl::SyncPoint>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<unsigned long&, ceph::common::CephContext*&>(std::allocator<librbd::cache::pwl::SyncPoint>, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:519:4
    #10 0x56440bd65371 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<librbd::cache::pwl::SyncPoint, std::allocator<librbd::cache::pwl::SyncPoint>, unsigned long&, ceph::common::CephContext*&>(librbd::cache::pwl::SyncPoint*&, std::_Sp_alloc_shared_tag<std::allocator<librbd::cache::pwl::SyncPoint>>, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:651:6
    #11 0x56440bd65163 in std::__shared_ptr<librbd::cache::pwl::SyncPoint, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<librbd::cache::pwl::SyncPoint>, unsigned long&, ceph::common::CephContext*&>(std::_Sp_alloc_shared_tag<std::allocator<librbd::cache::pwl::SyncPoint>>, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:1342:14
    #12 0x56440bd650e6 in std::shared_ptr<librbd::cache::pwl::SyncPoint>::shared_ptr<std::allocator<librbd::cache::pwl::SyncPoint>, unsigned long&, ceph::common::CephContext*&>(std::_Sp_alloc_shared_tag<std::allocator<librbd::cache::pwl::SyncPoint>>, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:409:4
    #13 0x56440bd65057 in std::shared_ptr<librbd::cache::pwl::SyncPoint> std::allocate_shared<librbd::cache::pwl::SyncPoint, std::allocator<librbd::cache::pwl::SyncPoint>, unsigned long&, ceph::common::CephContext*&>(std::allocator<librbd::cache::pwl::SyncPoint> const&, unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:862:14
    #14 0x56440bca97e7 in std::shared_ptr<librbd::cache::pwl::SyncPoint> std::make_shared<librbd::cache::pwl::SyncPoint, unsigned long&, ceph::common::CephContext*&>(unsigned long&, ceph::common::CephContext*&) /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:878:14
    #15 0x56440bd443c8 in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::new_sync_point(librbd::cache::pwl::DeferredContexts&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:1905:20
    #16 0x56440bd42e4c in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::flush_new_sync_point(librbd::cache::pwl::C_FlushRequest<librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>>*, librbd::cache::pwl::DeferredContexts&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:1951:3
    #17 0x56440bd9cbf2 in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::flush_new_sync_point_if_needed(librbd::cache::pwl::C_FlushRequest<librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>>*, librbd::cache::pwl::DeferredContexts&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:1990:5
    #18 0x56440bd9c636 in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::internal_flush(bool, Context*)::'lambda'(librbd::cache::pwl::GuardedRequestFunctionContext&)::operator()(librbd::cache::pwl::GuardedRequestFunctionContext&) const /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:2152:9
    #19 0x56440bd9b9b4 in boost::detail::function::void_function_obj_invoker<librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::internal_flush(bool, Context*)::'lambda'(librbd::cache::pwl::GuardedRequestFunctionContext&), void, librbd::cache::pwl::GuardedRequestFunctionContext&>::invoke(boost::detail::function::function_buffer&, librbd::cache::pwl::GuardedRequestFunctionContext&) /opt/ceph/include/boost/function/function_template.hpp:100:11
    #20 0x56440bd29321 in boost::function_n<void, librbd::cache::pwl::GuardedRequestFunctionContext&>::operator()(librbd::cache::pwl::GuardedRequestFunctionContext&) const /opt/ceph/include/boost/function/function_template.hpp:789:14
    #21 0x56440bd28d85 in librbd::cache::pwl::GuardedRequestFunctionContext::finish(int) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/Request.h:335:5
    #22 0x5644091e0fe0 in Context::complete(int) /home/jenkins-build/build/workspace/ceph-pull-requests/src/include/Context.h:102:5
    #23 0x56440bd9b378 in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::detain_guarded_request(librbd::cache::pwl::C_BlockIORequest<librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>>*, librbd::cache::pwl::GuardedRequestFunctionContext*, bool) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:1202:20
    #24 0x56440bd96c50 in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::internal_flush(bool, Context*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:2154:3
    #25 0x56440bd1e4b5 in librbd::cache::pwl::AbstractWriteLog<librbd::MockImageCtx>::shut_down(Context*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/cache/pwl/AbstractWriteLog.cc:703:3
    #26 0x56440bdb9022 in librbd::cache::pwl::TestMockCacheSSDWriteLog_compare_and_write_compare_matched_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/librbd/cache/pwl/test_mock_SSDWriteLog.cc:403:7
```

Fixes: https://tracker.ceph.com/issues/71335

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 05fd6f9)
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 077b738 to 6cbd81f Compare July 15, 2025 18:44
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to d50e7e2 chore(deps): update src/arrow digest to 9d00bc8 Jul 15, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 6cbd81f to ad0b54e Compare July 22, 2025 10:10
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 9d00bc8 chore(deps): update src/arrow digest to eed2789 Jul 22, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from ad0b54e to 4f8cf67 Compare July 22, 2025 13:43
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to eed2789 chore(deps): update src/arrow digest to 607be64 Jul 22, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 4f8cf67 to 659c91b Compare July 22, 2025 18:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 607be64 chore(deps): update src/arrow digest to 321cc1b Jul 22, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 659c91b to 4a3e2b8 Compare July 29, 2025 16:27
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 321cc1b chore(deps): update src/arrow digest to ea5dad5 Jul 29, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 4a3e2b8 to 07d1fc7 Compare August 5, 2025 05:47
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to ea5dad5 chore(deps): update src/arrow digest to d9618fe Aug 5, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 07d1fc7 to 56dc53b Compare August 5, 2025 12:42
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to d9618fe chore(deps): update src/arrow digest to 5f4ba59 Aug 5, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 56dc53b to a75de0d Compare August 12, 2025 13:08
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 5f4ba59 chore(deps): update src/arrow digest to 2dd3ccd Aug 12, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from a75de0d to 2fa453e Compare August 19, 2025 08:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 72b0346 chore(deps): update src/arrow digest to 37c87db Sep 23, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 4289779 to 7b7ffb6 Compare September 24, 2025 16:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 37c87db chore(deps): update src/arrow digest to 235032a Sep 24, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 7b7ffb6 to c8d8906 Compare September 25, 2025 12:10
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 235032a chore(deps): update src/arrow digest to 6a0ea6a Sep 25, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from c8d8906 to 6f980b7 Compare September 25, 2025 20:08
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 6a0ea6a chore(deps): update src/arrow digest to a91b264 Sep 25, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 6f980b7 to d1a2fe9 Compare September 26, 2025 00:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to a91b264 chore(deps): update src/arrow digest to 00439d1 Sep 26, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from d1a2fe9 to c454ba3 Compare September 26, 2025 08:11
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 00439d1 chore(deps): update src/arrow digest to 41659b8 Sep 26, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from c454ba3 to ad8b9f1 Compare September 26, 2025 16:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 41659b8 chore(deps): update src/arrow digest to 19e3f90 Sep 26, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from ad8b9f1 to 5c172f3 Compare September 27, 2025 12:12
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 19e3f90 chore(deps): update src/arrow digest to 9b96bdb Sep 27, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 5c172f3 to e4c771a Compare September 29, 2025 16:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 9b96bdb chore(deps): update src/arrow digest to 13c2615 Sep 29, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from e4c771a to 7cc1819 Compare October 1, 2025 00:10
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 13c2615 chore(deps): update src/arrow digest to 935f318 Oct 1, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 7cc1819 to e1eadb5 Compare October 1, 2025 08:10
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 935f318 chore(deps): update src/arrow digest to eb9d519 Oct 1, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from e1eadb5 to bb2483e Compare October 2, 2025 04:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to eb9d519 chore(deps): update src/arrow digest to 16ceade Oct 2, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from bb2483e to bdda191 Compare October 3, 2025 08:12
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to 16ceade chore(deps): update src/arrow digest to cde3f6a Oct 3, 2025
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from bdda191 to 7cb310c Compare October 3, 2025 16:08
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to cde3f6a chore(deps): update src/arrow digest to ef718a7 Oct 3, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
@konflux-internal-p02 konflux-internal-p02 bot force-pushed the konflux/mintmaker/release-8.1/src-arrow-digest branch from 7cb310c to 0cf7dda Compare October 4, 2025 04:09
@konflux-internal-p02 konflux-internal-p02 bot changed the title chore(deps): update src/arrow digest to ef718a7 chore(deps): update src/arrow digest to f7320c9 Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants