Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1136 reimplement getline #1138

Merged
merged 8 commits into from
May 20, 2019
Merged

Issue1136 reimplement getline #1138

merged 8 commits into from
May 20, 2019

Conversation

JayHuLBL
Copy link
Contributor

@JayHuLBL JayHuLBL commented May 2, 2019

Reimplement getline() funciton. Successfully tested on Windows OS.

@JayHuLBL JayHuLBL requested a review from mwetter May 2, 2019 00:13
@JayHuLBL JayHuLBL self-assigned this May 2, 2019
@JayHuLBL JayHuLBL mentioned this pull request May 2, 2019
Closed
@JayHuLBL
Copy link
Contributor Author

JayHuLBL commented May 2, 2019

@mwetter It's ready for review when CI test passed.

@JayHuLBL JayHuLBL requested a review from Mathadon May 2, 2019 00:44
@mwetter mwetter requested review from mlauster and nytschgeusen May 2, 2019 14:48
@mwetter mwetter removed the request for review from mlauster May 8, 2019 15:50
@PMehrfeld PMehrfeld self-requested a review May 8, 2019 15:59
@DaJansenGit DaJansenGit mentioned this pull request May 8, 2019
Closed
@JayHuLBL
Copy link
Contributor Author

@Mathadon @nytschgeusen
Would you please let me know if you approve the pull request?

Mathadon
Mathadon approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@Mathadon Mathadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for delay, was on holiday

@mwetter
Copy link
Contributor

mwetter commented May 20, 2019

I will merge this as the 2 weeks approval period is over, and Leuven and Aachen agreed to the changes.

@mwetter mwetter merged commit 74d7b50 into master May 20, 2019
@mwetter mwetter deleted the issue1136_reimplement_getline branch May 20, 2019 16:03
@JayHuLBL JayHuLBL mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter mwetter approved these changes

@Mathadon Mathadon Mathadon approved these changes

@PMehrfeld PMehrfeld PMehrfeld approved these changes

@nytschgeusen nytschgeusen Awaiting requested review from nytschgeusen

Assignees

@JayHuLBL JayHuLBL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JayHuLBL @mwetter @Mathadon @PMehrfeld