Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1981 heat pump medium declaration #1986

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Issue1981 heat pump medium declaration #1986

merged 2 commits into from
Mar 10, 2025

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Mar 7, 2025

This closes #1981.

mwetter added 2 commits March 7, 2025 13:08
@mwetter
Corrected format for revision note
108f88e 
This avoids the library name to be replaced when merging the library
@mwetter
Refactored to avoid replacing medium that is not replaceable
6cd5d3c 
For #1981
@mwetter mwetter enabled auto-merge March 7, 2025 21:11
@mwetter mwetter requested a review from FWuellhorst March 7, 2025 21:11
FWuellhorst
FWuellhorst approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Consider reverting the unwanted changes, as long as they are indeed unwanted.

@mwetter
Copy link
Contributor Author

mwetter commented Mar 10, 2025

@FWuellhorst : Thanks, I will merge it when the tests pass.
FYI, the non-related changes come from #1983

@mwetter mwetter merged commit 9beaf5b into master Mar 10, 2025
3 checks passed
@mwetter mwetter deleted the issue1981_heaPumMediumDeclaration branch March 10, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redeclare on non-replaceable package
2 participants
@mwetter @FWuellhorst