Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of scenario field in config.json #719

Open
dhblum opened this issue Dec 11, 2024 · 0 comments
Open

Remove use of scenario field in config.json #719

dhblum opened this issue Dec 11, 2024 · 0 comments
Assignees
Milestone

Comments

@dhblum
Copy link
Collaborator

dhblum commented Dec 11, 2024

Currently, there are default scenario fields defined in each test case's config.json, which are compiled into the FMU. However, all the configurations set electricity_price to constant and time_period to None. This can be done in testcase.py by default for all test cases. Then, the field can be removed from config.json and when new scenario fields are added (e.g. weather forecast uncertainty in #135 and likely more in future), all test case FMUs don't need to be recompiled with updated config.json.

This issue can be addressed by edits in testcase.py and the config.json files in each test case directory. However, test case FMUs do not need to be recompiled in my opinion to complete this issue. They can be updated over time as-needed by model or other structural changes.

dhblum added a commit that referenced this issue Dec 11, 2024
@dhblum dhblum added this to the v0.8.0 milestone Jan 3, 2025
@dhblum dhblum self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant