Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List<PeriodList> comparisons were not being handled correctly in Event's Equals and GetHashCode methods #275

Closed
rianjs opened this issue Apr 28, 2017 · 1 comment
Closed

List<PeriodList> comparisons were not being handled correctly in Event's Equals and GetHashCode methods #275

rianjs opened this issue Apr 28, 2017 · 1 comment
Assignees
@rianjs
Labels
bug

Comments

@rianjs
Copy link
Collaborator

rianjs commented Apr 28, 2017

RecurrenceDates, ExceptionDates are lists of lists. We need to contrive a normalized form for these elements, otherwise we can't do accurate comparisons or hashing.

More work to be done as part of #274 -- most of this logic should be lifted into the parent types, not done in Event directly. Baby steps.
@rianjs rianjs self-assigned this Apr 28, 2017
@rianjs rianjs added the bug label Apr 28, 2017
rianjs pushed a commit that referenced this issue Apr 28, 2017
List<PeriodList> comparisons were being handled incorrectly: only the…
b630dc6 
… top

level was being compared, and even that was of dubious correctness.
Instead, we need to normalize the EXDATEs and RDATEs, separated by
timezones.

Similarly, we need to pay attention to collections of collections when
determining whether two events are equal in both Equals and GetHashCode #275
rianjs pushed a commit that referenced this issue Apr 28, 2017
Bump nuspec files and annotate readme #275
c864f95
@rianjs rianjs closed this as completed Apr 28, 2017
@rianjs
Copy link
Collaborator Author

rianjs commented Apr 28, 2017

nuget:

  • 2.2.36
  • 3.0.5-net-core-alpha

rianjs pushed a commit that referenced this issue Apr 28, 2017
Subtle bug: the implementation of GetHashCode in CollectionHelpers wa…
d301dd5 
…s order-dependent which is unacceptable in unordered collections. Updated associated unit test so it will break if order matters #275
@rianjs rianjs mentioned this issue Apr 28, 2017
Merged
rianjs pushed a commit that referenced this issue May 1, 2017
Fixed an ordering bug in event equality #275
b73e843
rianjs pushed a commit that referenced this issue May 1, 2017
Better CalDateTime equality and hashing for timezone-sensitive compar…
c940693 
…isons. A few tweaks to Alarm unit tests because we only care about the absolute time coordinate for testing when they will trigger. Timezones are irrelevant #275
rianjs pushed a commit that referenced this issue May 1, 2017
Bump nuget versions and update release notes. Again #275
582fd4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rianjs rianjs

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rianjs