Fix weekly bymonth #880
Merged
Fix weekly bymonth #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weekly rules that include BYMONTH were only including weeks that start inside the given months. This fix checks the end of the week also to see if any part of the week is inside the given months. The date will not always be the start of a week, since the reference date is first, but extra months are filtered out later. Fixes ical-org#879
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #880 +/- ##
=====================================
Coverage 68.1% 68.2%
=====================================
Files 115 115
Lines 4354 4357 +3
Branches 1004 1007 +3
=====================================
+ Hits 2967 2970 +3
Misses 1028 1028
Partials 359 359
🚀 New features to boost your workflow:
|
This was referenced Nov 13, 2025
This was referenced Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekly rules that include BYMONTH were only including weeks that start inside the given months. This fix checks the end of the week also to see if any part of the week is inside the given months.
The date will not always be the start of a week, since the reference date is first, but extra months are filtered out later.
Fixes #879