Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempting to fix OutputFileValidator so that whatever views are specified via ignore_views_for_output are not used to generate the output files and schema and are not used for comparison #117

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

attempting to fix OutputFileValidator so that whatever views are specified via ignore_views_for_output are not used to generate the output files and schema and are not used for comparison #117

wants to merge 4 commits into from

Conversation

dcanbwell
Copy link

  • attempting to fix OutputFileValidator so that whatever views are specified via ignore_views_for_output are not used to generate the output files and schema and are not used for comparison

@dcanbwell
attempting to fix OutputFileValidator so that whatever views are spec…
735eb9f 
…ified via ignore_views_for_output are not used to generate the output files and schema and are not used for comparison
@dcanbwell
changed to the proper way of stripping out the file extension to see …
b6490cd 
…which views should be ignored based on the ignore_views_for_output setting
@dcanbwell
ignore mypy's unnecessary complaints
d66715c
@dcanbwell
changed the default value from None to an empty list for ignore_views…
0a2300b 
…_for_output of the OutputFileValidator (previous mypy complaints turned out to be totally valid; my bad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragverma099 anuragverma099 anuragverma099 approved these changes

@odebarros odebarros odebarros approved these changes

@imranq2 imranq2 Awaiting requested review from imranq2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcanbwell @odebarros @anuragverma099