Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding duplicate languages in metadata #42

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Prevent adding duplicate languages in metadata #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lgr/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ def add_language(self, language, force=False):
raise LGRFormatException(LGRFormatException.
LGRFormatReason.INVALID_LANGUAGE_TAG)
self.rfc7940_checks.tested('metadata_language')
self.languages.append(language)
if language not in self.languages:
self.languages.append(language)
except UnicodeEncodeError:
# Can't skip this one
logger.error("Invalid non-ASCII language tag '%s'", language)
Expand Down
11 changes: 8 additions & 3 deletions tests/unit/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@
"""
test_metadata.py - Unit testing of metadata module.
"""
from __future__ import unicode_literals

import unittest

from lgr.metadata import Metadata, ReferenceManager
from lgr.exceptions import (LGRFormatException,
ReferenceAlreadyExists,
ReferenceInvalidId,
ReferenceNotDefined)
from lgr.metadata import Metadata, ReferenceManager


class TestMetadata(unittest.TestCase):
Expand Down Expand Up @@ -43,6 +41,12 @@ def test_add_language(self):
self.assertEqual(the_exception.reason,
LGRFormatException.LGRFormatReason.INVALID_LANGUAGE_TAG)

def test_add_language_does_not_add_duplicate(self):
self.metadata.add_language('fr')
self.metadata.add_language('fr')

self.assertListEqual(self.metadata.languages, ['fr'])

def test_add_language_force(self):
self.metadata.add_language('fr', force=True)
self.metadata.add_language('de-419-DE', force=True)
Expand Down Expand Up @@ -190,6 +194,7 @@ def test_update_inexsting_reference(self):
self.manager.update_reference, 1,
**{'value': 'The Unicode Standard 1.2'})


if __name__ == '__main__':
import logging
logging.getLogger('lgr').addHandler(logging.NullHandler())
Expand Down