Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #13 by getting rid of .mjs extension #14

Merged
merged 1 commit into from
Dec 30, 2017
Merged

Fixes issue #13 by getting rid of .mjs extension #14

merged 1 commit into from
Dec 30, 2017

Conversation

icd2k3
Copy link
Owner

@icd2k3 icd2k3 commented Dec 30, 2017 •
edited
Loading

#13

Seems there is an issue with create-react-app handling files with .mjs extensions. This PR changes the build output from dist/index.mjs and dist/index.js to dist/es/index.js and dist/umd/index.js respectively

Similar issues:
szimek/signature_pad#257
facebook/create-react-app#3237

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 473ffc8 on fix-13 into a81eb02 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 58db04c on fix-13 into a81eb02 on master.

@icd2k3 icd2k3 merged commit caf981b into master Dec 30, 2017
@icd2k3 icd2k3 mentioned this pull request Dec 30, 2017
Closed
@icd2k3 icd2k3 deleted the fix-13 branch December 30, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icd2k3 @coveralls