This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
feat: support crossorigin #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
可以补充一下文档 |
|
同步一下文档 |
wssgcg1213
previously approved these changes
Nov 2, 2022
luhc228
reviewed
Nov 3, 2022
website/docs/guide/basic/config.md
Outdated
| import { defineConfig } from '@ice/app'; | ||
|
|
||
| export default defineConfig({ | ||
| define: { |
There was a problem hiding this comment.
crossOriginLoading 为什么是在 define 对象里面？跟上面的类型定义不一致
luhc228
reviewed
Nov 4, 2022
website/docs/guide/basic/config.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| 指定 webpack 启用 cross-origin 去加载 chunk. |
There was a problem hiding this comment.
- 指定 webpack 启用 cross-origin 去加载 chunk.
+ 指定 webpack 启用 [cross-origin](https://webpack.js.org/configuration/output/#outputcrossoriginloading) 去加载 chunk。好处是可以通过链接跳过让用户知道 crossOriginLoading 每个参数的含义是什么？
luhc228
previously approved these changes
Nov 4, 2022
ClarkXia
previously approved these changes
Nov 4, 2022
chenjun1011
dismissed stale reviews from ClarkXia and luhc228
The base branch was changed.
luhc228
approved these changes
Nov 4, 2022
ClarkXia
approved these changes
Nov 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持透传 crossorigin
异步加载的 chunk 也需要开启 crossorigin，才能让 JSTracker 捕获 JS Error 的具体信息
https://webpack.js.org/configuration/output/#outputcrossoriginloading