This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
feat: config polyfill for bowsers support #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luhc228
previously approved these changes
Nov 4, 2022
luhc228
approved these changes
Nov 4, 2022
chenjun1011
reviewed
Nov 4, 2022
| @@ -68,6 +68,8 @@ export function createServerCompiler(options: Options) { | |||
| const transformPlugins = getCompilerPlugins({ | |||
| ...task.config, | |||
| fastRefresh: false, | |||
| env: false, | |||
There was a problem hiding this comment.
server 端不需要注入 env 相关的 target，esbuild 默认会处理编译到 node 12
chenjun1011
reviewed
Nov 4, 2022
chenjun1011
approved these changes
Nov 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对于
...obj语法，编译工具会直接进行转化，而对于Set等语法，需要通过引入 polyfill 进行处理 #95。因此框架内置目前未处理 Polyfill 逻辑，本次修改涉及以下逻辑：
externalHelpers，basic-project 项目构建大小减小 5KB 左右（视项目大小和 ES 语法的多少会有明显优势）