This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
fix: request in data loader #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ClarkXia
reviewed
Nov 4, 2022
| @@ -45,7 +45,7 @@ export default class DataLoaderPlugin { | |||
| }, | |||
| { | |||
| swc: { | |||
| keepExports: ['getData', 'getAppData'], | |||
| keepExports: ['getData', 'getAppData', 'request'], | |||
There was a problem hiding this comment.
这个配置能做到移除 src/app 的其他导出，包括立即执行么？另外可以在插件上增加一个配置，不一定耦合 request
answershuto
reviewed
Nov 4, 2022
| }, | ||
| }; | ||
|
|
||
| if (runtimeModules) { |
There was a problem hiding this comment.
通过插件注册的一些运行时模块，比如 request 插件，会配置请求的 baseUrl，需要对 data-loader 生效
ClarkXia
reviewed
Nov 4, 2022
|
|
||
| <% if(!dataLoaderImport.imports) {-%> | ||
| let fetcher = (options) => { | ||
| window.fetch(options.url, options); | ||
| } | ||
| <% } -%> | ||
|
|
||
| dataLoader.init(loaders, fetcher); | ||
| const statics = [ |
There was a problem hiding this comment.
在命名上可以明确掉是运行时模式
// Only init static runtime in data-loader.
const staticRuntimes = [
ClarkXia
approved these changes
Nov 7, 2022
answershuto
approved these changes
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #600