fix: 🐛 add missing props for lifecycles (#440)

ice-lab · Dec 3, 2021 · 84dead4 · 84dead4
1 parent 2a0dd5d
commit 84dead4
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/packages/icestark-app/CHANGELOG.md b/packages/icestark-app/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.4.3
+
+- [fix] add missing props for `registerAppEnter` & `registerAppLeave`.
+
 ## 1.4.2
 
 - [fix] Bind history to window when using `AppLink`. ([#428](https://github.com/ice-lab/icestark/pull/428))

diff --git a/packages/icestark-app/package.json b/packages/icestark-app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ice/stark-app",
-  "version": "1.4.2",
+  "version": "1.4.3",
   "description": "icestark-app is a JavaScript library for icestark, used by sub-application.",
   "scripts": {
     "build": "rm -rf lib && tsc",

diff --git a/packages/icestark-app/src/index.ts b/packages/icestark-app/src/index.ts
@@ -8,3 +8,5 @@ export { default as appHistory } from './appHistory';
 export { default as isInIcestark } from './isInIcestark';
 export { default as AppLink } from './AppLink';
 export { default as setLibraryName } from './setLibraryName';
+
+export type { LifecycleProps } from './registerAppEnter';
diff --git a/packages/icestark-app/src/registerAppEnter.ts b/packages/icestark-app/src/registerAppEnter.ts
@@ -1,6 +1,11 @@
 import { setCache } from './cache';
 
-export default (callback?: () => void): void => {
+export interface LifecycleProps {
+  container: HTMLElement | string;
+  customProps?: object;
+}
+
+export default (callback?: (props: LifecycleProps) => void): void => {
   if (!callback) return;
 
   if (typeof callback !== 'function') {

diff --git a/packages/icestark-app/src/registerAppLeave.ts b/packages/icestark-app/src/registerAppLeave.ts
@@ -1,6 +1,7 @@
 import { setCache } from './cache';
+import type { LifecycleProps } from './registerAppEnter';
 
-export default (callback?: () => void): void => {
+export default (callback?: (props: LifecycleProps) => void): void => {
   if (!callback) return;
 
   if (typeof callback !== 'function') {