feat: 🎸 add loadMode #221
Closed
feat: 🎸 add loadMode #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maoxiaoke
commented
Jan 6, 2021
•
maoxiaoke
commented
- support loadMode
Closed
ClarkXia
reviewed
Jan 11, 2021
| // cache loadMode | ||
| // eslint-disable-next-line no-nested-ternary | ||
| const loadMode = umd ? 'umd' : ( sandbox ? 'sandbox' : 'script' ); | ||
| setCache('loadMode', loadMode); |
There was a problem hiding this comment.
这个设置时机是不是没解决多个 app 在不同 loadMode 的问题
src/apps.ts
Outdated
| @@ -278,6 +298,8 @@ export async function unloadMicroApp(appName: string) { | |||
| delete appConfig.unmount; | |||
| delete appConfig.appAssets; | |||
| updateAppConfig(appName, { status: NOT_LOADED }); | |||
|
|
|||
| removeContent(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.