fix: 🐛 catch javascript runtime error

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ice/stark",
-  "version": "2.6.1",
+  "version": "2.6.2",
   "description": "Icestark is a JavaScript library for multiple projects, Ice workbench solution.",
   "scripts": {
     "install:deps": "rm -rf node_modules && rm -rf ./packages/*/node_modules && yarn install && lerna exec -- npm install",

src/util/handleAssets.ts

@@ -57,6 +57,21 @@ export interface ILifecycleProps {
   customProps?: object;
 }
 
+function isAssetExist(element: HTMLScriptElement | HTMLLIElement, type: 'script' | 'link') {
+  const urlAlias = type === 'script' ? 'src' : 'href';
+
+  return Array.from(document.getElementsByTagName(type))
+    .some((item) => {
+      if (
+        item[urlAlias]
+        && element[urlAlias] === item[urlAlias]
+      ) {
+        return true;
+      }
+      return false;
+    });
+}
+
 /**
  * Create link/style element and append to root
  */
@@ -228,13 +243,31 @@ export function appendExternalScript(asset: string | Asset,
       return;
     }
 
+    if (isAssetExist(element, 'script')) {
+      resolve();
+    }
+
     setAttributeForScriptNode(element, {
       module,
       id,
       src: content || (asset as string),
       scriptAttributes,
     });
 
+    /**
+    * For JavaScript runtime error may not fire error event (https://github.com/ice-lab/icestark/issues/419).
+    * While window.onerror is supported to catch JavaScript runtime error.
+    */
+    const rejectRuntimeError = (event: ErrorEvent) => {
+      if (event?.filename === (content || asset)) {
+        reject(new Error(`js asset runtime error: ${event?.message}`));
+      }
+
+      window.removeEventListener('error', rejectRuntimeError);
+    };
+
+    window.addEventListener('error', rejectRuntimeError);
+
     element.addEventListener(
       'error',
       () => reject(new Error(`js asset loaded error: ${content || asset}`)),