Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use glsl version 1.50 on OSX #24

Merged
merged 1 commit into from
Mar 3, 2019
Merged

use glsl version 1.50 on OSX #24

merged 1 commit into from
Mar 3, 2019

Conversation

Jason0214
Copy link
Contributor

fix #20, but may need some test on other platforms

@ice1000 ice1000 self-requested a review March 3, 2019 03:02
@ice1000 ice1000 self-assigned this Mar 3, 2019
@ice1000 ice1000 added bug Something isn't working compatibility Cross-platform is really hard labels Mar 3, 2019
ice1000
ice1000 approved these changes Mar 3, 2019
View reviewed changes
Copy link
Owner

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice1000 ice1000 merged commit d19234c into ice1000:master Mar 3, 2019
@Jason0214 Jason0214 mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice1000 ice1000 ice1000 approved these changes

Assignees

@ice1000 ice1000

Labels
bug Something isn't working compatibility Cross-platform is really hard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImGui implOpenGL3 default use glsl version 1.30, not supported on some macOS
2 participants
@Jason0214 @ice1000